chrome/browser/ui/passwords/manage_passwords_ui_controller.h - Issue 777423004: Skeleton code for experiment setup, which will determine should "Allow to collect URL?" bubble be s…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Issue 777423004: Skeleton code for experiment setup, which will determine should "Allow to collect URL?" bubble be s… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('j') | chrome/common/pref_names.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

index faf3fb86b218aa3c4a4d930a50de53def560551b..ad6c19e01161e2e7f05805e5918b4aea3f79bf16 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

@@ -76,6 +76,10 @@ class ManagePasswordsUIController

// and WILL be in MANAGE_STATE after this method executes.

virtual void SavePassword();

+ // Called from the model when user allows to send feedback with URL of

+ // page where password manager has failed.

+ void SendURLFeedback();

// Called from the model when the user chooses a credential.

// The controller MUST be in a pending credentials state.

virtual void ChooseCredential(bool was_chosen,

@@ -162,6 +166,8 @@ class ManagePasswordsUIController

private:

friend class content::WebContentsUserData<ManagePasswordsUIController>;

+ class URLCollectionFeedbackSender;

// Shows the password bubble without user interaction. The controller MUST

// be in PENDING_PASSWORD_AND_BUBBLE_STATE.

void ShowBubbleWithoutUserInteraction();