Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: perf/go/shortcut/shortcut.go

Issue 777413002: Add new tests to presubmit, fix errors (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Run "go vet" once in the root dir Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: perf/go/shortcut/shortcut.go
diff --git a/perf/go/shortcut/shortcut.go b/perf/go/shortcut/shortcut.go
index 810f2389f33f327bec715b09e4c942234395a43b..1a5791d405446944ffe044084c49fa8e06046cd5 100644
--- a/perf/go/shortcut/shortcut.go
+++ b/perf/go/shortcut/shortcut.go
@@ -27,11 +27,11 @@ func Insert(r io.Reader) (string, error) {
}
result, err := db.DB.Exec(`INSERT INTO shortcuts (traces) VALUES (?)`, string(b))
if err != nil {
- return "", fmt.Errorf("Error while inserting shortcut: err", err)
+ return "", fmt.Errorf("Error while inserting shortcut: %v", err)
}
id, err := result.LastInsertId()
if err != nil {
- return "", fmt.Errorf("Error retrieving ID of new shortcut:", err)
+ return "", fmt.Errorf("Error retrieving ID of new shortcut: %v", err)
}
return fmt.Sprintf("%d", id), nil
}
« no previous file with comments | « perf/go/ingester/ingester_test.go ('k') | perf/go/skiaperf/main.go » ('j') | run_unittests » ('J')

Powered by Google App Engine
This is Rietveld 408576698