Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Unified Diff: monitoring/go/alertserver/main.go

Issue 777413002: Add new tests to presubmit, fix errors (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: rebase Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « go/skiaversion/skiaversion.go ('k') | monitoring/go/buildbot_ingest/bycommit.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: monitoring/go/alertserver/main.go
diff --git a/monitoring/go/alertserver/main.go b/monitoring/go/alertserver/main.go
index 7939e45a7c753b6bd7e63276503ed3990d08a72d..a8a9c8cef7ed8597af02dc1e32aab5de00db4f4a 100644
--- a/monitoring/go/alertserver/main.go
+++ b/monitoring/go/alertserver/main.go
@@ -130,7 +130,7 @@ func alertHandler(w http.ResponseWriter, r *http.Request) {
}
alertId := split[2]
if !alertManager.Contains(alertId) {
- util.ReportError(w, r, fmt.Errorf("Invalid Alert ID %d", alertId), "The requested resource does not exist.")
+ util.ReportError(w, r, fmt.Errorf("Invalid Alert ID %s", alertId), "The requested resource does not exist.")
return
}
action := split[3]
@@ -243,7 +243,15 @@ func main() {
*influxDbName = metadata.MustGet(INFLUXDB_NAME_METADATA_KEY)
*influxDbPassword = metadata.MustGet(INFLUXDB_PASSWORD_METADATA_KEY)
}
- dbClient, err := client.New(&client.ClientConfig{*influxDbHost, *influxDbName, *influxDbPassword, *influxDbDatabase, nil, false, false})
+ dbClient, err := client.New(&client.ClientConfig{
+ Host: *influxDbHost,
+ Username: *influxDbName,
+ Password: *influxDbPassword,
+ Database: *influxDbDatabase,
+ HttpClient: nil,
+ IsSecure: false,
+ IsUDP: false,
+ })
if err != nil {
glog.Fatalf("Failed to initialize InfluxDB client: %s", err)
}
« no previous file with comments | « go/skiaversion/skiaversion.go ('k') | monitoring/go/buildbot_ingest/bycommit.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698