ct/go/util/gs.go - Issue 777413002: Add new tests to presubmit, fix errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ct/go/util/gs.go

Issue 777413002: Add new tests to presubmit, fix errors (Closed) Base URL: https://skia.googlesource.com/buildbot@master

Patch Set: rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ct/go/util/gs.go

diff --git a/ct/go/util/gs.go b/ct/go/util/gs.go

index 0decd4f4455f68b6b21b792fbd34116dc4a7a183..279993c7288cea199d96ea6089831cfb60ab0043 100644

--- a/ct/go/util/gs.go

+++ b/ct/go/util/gs.go

@@ -140,7 +140,7 @@ func (gs *GsUtil) DownloadWorkerArtifacts(dirName, pagesetType string, workerNum

fileName := filepath.Base(result.Name)

wg.Add(1)

- go func() {

+ go func(result *storage.Object) {

defer wg.Done()

respBody, err := getRespBody(result, gs.client)

if err != nil {

@@ -160,7 +160,7 @@ func (gs *GsUtil) DownloadWorkerArtifacts(dirName, pagesetType string, workerNum

return

}

glog.Infof("Downloaded gs://%s/%s to %s", GS_BUCKET_NAME, result.Name, outputFile)

- }()

+ }(result)

}

if len(resp.NextPageToken) > 0 {

req.PageToken(resp.NextPageToken)

« no previous file with comments | « ct/go/util/constants.go ('k') | ct/go/util/util_test.go » ('j') | no next file with comments »