Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: perf/go/trybot/trybot.go

Issue 777413002: Add new tests to presubmit, fix errors (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Run "go vet" once in the root dir Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /** trybot is for loading and serving trybot performance results. 1 /** trybot is for loading and serving trybot performance results.
2 2
3 Implementation notes: 3 Implementation notes:
4 4
5 Regular files are in: 5 Regular files are in:
6 6
7 gs://chromium-skia-gm/nano-json-v1/2014/08/07/01/Perf-...-Release/nanobench_ da7a94...8d35a_1407357280.json 7 gs://chromium-skia-gm/nano-json-v1/2014/08/07/01/Perf-...-Release/nanobench_ da7a94...8d35a_1407357280.json
8 8
9 while trybots are in: 9 while trybots are in:
10 10
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 for _, b := range benchFilesByIssue { 202 for _, b := range benchFilesByIssue {
203 if b.IssueName != lastIssue { 203 if b.IssueName != lastIssue {
204 // Write out the current TryBotResults to the datastore and create a fresh new TryBotResults. 204 // Write out the current TryBotResults to the datastore and create a fresh new TryBotResults.
205 if cur != nil { 205 if cur != nil {
206 if err := Write(lastIssue, cur); err != nil { 206 if err := Write(lastIssue, cur); err != nil {
207 return fmt.Errorf("Update failed to writ e trybot results: %s", err) 207 return fmt.Errorf("Update failed to writ e trybot results: %s", err)
208 } 208 }
209 } 209 }
210 if cur, err = Get(b.IssueName); err != nil { 210 if cur, err = Get(b.IssueName); err != nil {
211 return fmt.Errorf("Failed to load existing trybo t data for issue %s: %s", b.IssueName, err) 211 return fmt.Errorf("Failed to load existing trybo t data for issue %s: %s", b.IssueName, err)
212 continue
213 } 212 }
214 lastIssue = b.IssueName 213 lastIssue = b.IssueName
215 glog.Infof("Switched to issue: %s", lastIssue) 214 glog.Infof("Switched to issue: %s", lastIssue)
216 } 215 }
217 addTryData(cur, b.ResultsFileLocation, counter) 216 addTryData(cur, b.ResultsFileLocation, counter)
218 } 217 }
219 if cur != nil { 218 if cur != nil {
220 if err := Write(lastIssue, cur); err != nil { 219 if err := Write(lastIssue, cur); err != nil {
221 return fmt.Errorf("Update failed to write trybot results : %s", err) 220 return fmt.Errorf("Update failed to write trybot results : %s", err)
222 } 221 }
223 } 222 }
224 223
225 glog.Infof("Finished trybot ingestion.") 224 glog.Infof("Finished trybot ingestion.")
226 225
227 return nil 226 return nil
228 } 227 }
OLDNEW
« no previous file with comments | « perf/go/skiaperf/main.go ('k') | perf/go/vec/vec_test.go » ('j') | run_unittests » ('J')

Powered by Google App Engine
This is Rietveld 408576698