Add new tests to presubmit, fix errors

monitoring/go/alertserver/main.go

 /*
         Provides roll-up statuses and alerting for Skia build/test/perf.
 */
 
 package main
 
 import (
         "encoding/json"
         "flag"
         "fmt"
@@ skipping 112 matching lines @@
                         return
                 }
                 // URLs take the form /alerts/<alertId>/<action>
                 split := strings.Split(r.URL.String(), "/")
                 if len(split) != 4 {
                         util.ReportError(w, r, fmt.Errorf("Invalid URL %s", r.URL), "Requested URL is not valid.")
                         return
                 }
                 alertId := split[2]
                 if !alertManager.Contains(alertId) {
-                        util.ReportError(w, r, fmt.Errorf("Invalid Alert ID %d", alertId), "The requested resource does not exist.")
+                        util.ReportError(w, r, fmt.Errorf("Invalid Alert ID %s", alertId), "The requested resource does not exist.")
                         return
                 }
                 action := split[3]
                 if action == "dismiss" {
                         glog.Infof("%s %s", action, alertId)
                         alertManager.Dismiss(alertId, email)
                         return
                 } else if action == "snooze" {
                         d := json.NewDecoder(r.Body)
                         body := struct {
@@ skipping 92 matching lines @@
         if err != nil {
                 glog.Fatalf("Failed to parse -alertPollInterval: %s", *alertPollInterval)
         }
         if *testing {
                 *useMetadata = false
         }
         if *useMetadata {
                 *influxDbName = metadata.MustGet(INFLUXDB_NAME_METADATA_KEY)
                 *influxDbPassword = metadata.MustGet(INFLUXDB_PASSWORD_METADATA_KEY)
         }
-        dbClient, err := client.New(&client.ClientConfig{*influxDbHost, *influxDbName, *influxDbPassword, *influxDbDatabase, nil, false, false})
+        dbClient, err := client.New(&client.ClientConfig{
+                Host:       *influxDbHost,
+                Username:   *influxDbName,
+                Password:   *influxDbPassword,
+                Database:   *influxDbDatabase,
+                HttpClient: nil,
+                IsSecure:   false,
+                IsUDP:      false,
+        })
         if err != nil {
                 glog.Fatalf("Failed to initialize InfluxDB client: %s", err)
         }
         serverURL := "https://" + *host
         if *testing {
                 serverURL = "http://" + *host + *port
         }
 
         usr, err := user.Current()
         if err != nil {
@@ skipping 38 matching lines @@
         if err != nil {
                 glog.Fatalf("Failed to create AlertManager: %v", err)
         }
 
         gitInfo, err = gitinfo.CloneOrUpdate("https://skia.googlesource.com/skia.git", *workdir, true)
         if err != nil {
                 glog.Fatalf("Failed to check out Skia: %v", err)
         }
         runServer(serverURL)
 }