content/child/webcrypto/openssl/sym_key_openssl.cc - Issue 777403004: [WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/webcrypto/openssl/sym_key_openssl.cc

Issue 777403004: [WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated code to adapt to new changes + code review comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/webcrypto/openssl/sym_key_openssl.cc

diff --git a/content/child/webcrypto/openssl/sym_key_openssl.cc b/content/child/webcrypto/openssl/sym_key_openssl.cc

index eadf73cf2ac5acffcf8088b2e743a8b2827dcea3..addc1ccf80862c52a5b84fb8e767991023829a00 100644

--- a/content/child/webcrypto/openssl/sym_key_openssl.cc

+++ b/content/child/webcrypto/openssl/sym_key_openssl.cc

@@ -26,9 +26,6 @@ Status GenerateSecretKeyOpenSsl(const blink::WebCryptoKeyAlgorithm& algorithm,

GenerateKeyResult* result) {

crypto::OpenSSLErrStackTracer err_tracer(FROM_HERE);

- if (usages == 0)

- return Status::ErrorCreateKeyEmptyUsages();

unsigned int keylen_bytes = NumBitsToBytes(keylen_bits);

std::vector<unsigned char> random_bytes(keylen_bytes, 0);

« no previous file with comments | « content/child/webcrypto/openssl/hmac_openssl.cc ('k') | content/child/webcrypto/status.h » ('j') | content/child/webcrypto/status.cc » ('J')