content/child/webcrypto/nss/rsa_key_nss.cc - Issue 777403004: [WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/webcrypto/nss/rsa_key_nss.cc

Issue 777403004: [WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated code to adapt to new changes + code review comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/webcrypto/nss/rsa_key_nss.cc

diff --git a/content/child/webcrypto/nss/rsa_key_nss.cc b/content/child/webcrypto/nss/rsa_key_nss.cc

index 943d18f124aa7c8a9384392abb07ed374daaf5b1..8e657414759c9360833f0acffe1cdea94b7d3e0d 100644

--- a/content/child/webcrypto/nss/rsa_key_nss.cc

+++ b/content/child/webcrypto/nss/rsa_key_nss.cc

@@ -745,9 +745,9 @@ Status RsaHashedAlgorithm::ImportKeyJwk(

// Once the key type is known, verify the usages.

status = CheckKeyCreationUsages(

jwk.is_private_key ? all_private_key_usages_ : all_public_key_usages_,

- usages);

+ usages, jwk.is_private_key);

if (status.IsError())

- return Status::ErrorCreateKeyBadUsages();

+ return status;

return jwk.is_private_key

? ImportRsaPrivateKey(algorithm, extractable, usages, jwk, key)

« no previous file with comments | « content/child/webcrypto/nss/hmac_nss.cc ('k') | content/child/webcrypto/nss/sym_key_nss.cc » ('j') | content/child/webcrypto/status.cc » ('J')