content/child/webcrypto/webcrypto_util.h - Issue 777403004: [WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/webcrypto/webcrypto_util.h

Issue 777403004: [WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved import key empty usage to CheckKeyCreationUsages Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/webcrypto/test/rsa_ssa_unittest.cc ('K') | « content/child/webcrypto/test/rsa_ssa_unittest.cc ('k') | content/child/webcrypto/webcrypto_util.cc » ('j') | content/child/webcrypto/webcrypto_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/webcrypto/webcrypto_util.h

diff --git a/content/child/webcrypto/webcrypto_util.h b/content/child/webcrypto/webcrypto_util.h

index fdfea99316d02933d3d9f503f25b09f6beb630a6..d16ddc6d4f8f9b9897b88e3339b789272d409e2e 100644

--- a/content/child/webcrypto/webcrypto_util.h

+++ b/content/child/webcrypto/webcrypto_util.h

@@ -68,7 +68,8 @@ Status GetHmacKeyGenLengthInBits(const blink::WebCryptoHmacKeyGenParams* params,

Status VerifyAesKeyLengthForImport(unsigned int keylen_bytes);

Status CheckKeyCreationUsages(blink::WebCryptoKeyUsageMask all_possible_usages,

- blink::WebCryptoKeyUsageMask actual_usages);

+ blink::WebCryptoKeyUsageMask actual_usages,

+ bool checkImportKeyEmptyUsage = false);

eroman 2014/12/09 17:42:55 The style forbids default parameters, and also thi

// Extracts the public exponent and modulus length from the Blink parameters.

// On success it is guaranteed that: