Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: content/child/webcrypto/test/aes_kw_unittest.cc

Issue 777403004: [WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated issues in ecdh tests and other review comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/webcrypto/test/aes_kw_unittest.cc
diff --git a/content/child/webcrypto/test/aes_kw_unittest.cc b/content/child/webcrypto/test/aes_kw_unittest.cc
index b439ba4dffe3d45b3d73e6c8b192ac9074d0eab2..c7858e16cfd3426ca0f905f85f67942b73edb839 100644
--- a/content/child/webcrypto/test/aes_kw_unittest.cc
+++ b/content/child/webcrypto/test/aes_kw_unittest.cc
@@ -29,8 +29,8 @@ TEST(WebCryptoAesKwTest, GenerateKeyBadLength) {
for (size_t i = 0; i < arraysize(kKeyLen); ++i) {
SCOPED_TRACE(i);
EXPECT_EQ(Status::ErrorGenerateAesKeyLength(),
- GenerateSecretKey(CreateAesKwKeyGenAlgorithm(kKeyLen[i]), true, 0,
- &key));
+ GenerateSecretKey(CreateAesKwKeyGenAlgorithm(kKeyLen[i]), true,
+ blink::WebCryptoKeyUsageWrapKey, &key));
}
}
@@ -40,6 +40,15 @@ TEST(WebCryptoAesKwTest, GenerateKeyEmptyUsage) {
GenerateSecretKey(CreateAesKwKeyGenAlgorithm(256), true, 0, &key));
}
+TEST(WebCryptoAesKwTest, ImportKeyEmptyUsage) {
+ blink::WebCryptoKey key;
+ EXPECT_EQ(Status::ErrorCreateKeyEmptyUsages(),
+ ImportKey(blink::WebCryptoKeyFormatRaw,
+ CryptoData(std::vector<uint8_t>(16)),
+ CreateAlgorithm(blink::WebCryptoAlgorithmIdAesKw),
+ true, 0, &key));
+}
+
TEST(WebCryptoAesKwTest, ImportKeyJwkKeyOpsWrapUnwrap) {
blink::WebCryptoKey key;
base::DictionaryValue dict;

Powered by Google App Engine
This is Rietveld 408576698