Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 77733005: Experimental lexer generator: rename_things(Dfa minimization) += comments (Closed)

Created:
7 years, 1 month ago by marja
Modified:
7 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Experimental lexer generator: rename_things(Dfa minimization) += comments - DfaState.key_matches -> transition_state_with_key. - action_map -> initial_partitions - __partition -> __create_initial_partitions - if k[0] == "terminal_set" or k[0] == "terminal action" or True: this always happens - other small variable renamings around transition -> transition_state BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17895

Patch Set 1 #

Patch Set 2 : comments from dcarney #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -25 lines) Patch
M tools/lexer_generator/dfa.py View 1 6 chunks +58 lines, -25 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dcarney
lgtm
7 years, 1 month ago (2013-11-20 08:58:10 UTC) #1
marja
7 years, 1 month ago (2013-11-20 08:59:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r17895.

Powered by Google App Engine
This is Rietveld 408576698