Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 777303002: Update cpplint.py to r141.

Created:
6 years ago by Alex Vakulenko (Google)
Modified:
5 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools@master
Project:
tools
Visibility:
Public.

Description

Update cpplint.py to r141. This just a copy of cpplint.py from upstream [1]. [1] https://code.google.com/p/google-styleguide/source/detail?spec=svn141&r=141 BUG=None Change-Id: I4dca890d5f02957ddae33c4bd4269fd37758be3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -169 lines) Patch
M cpplint.py View 42 chunks +348 lines, -169 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Alex Vakulenko (Google)
6 years ago (2014-12-04 22:24:30 UTC) #2
M-A Ruel
rubberstamp lgtm
6 years ago (2014-12-04 22:35:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777303002/1
6 years ago (2014-12-04 22:39:46 UTC) #5
commit-bot: I haz the power
Presubmit check for 777303002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-12-04 22:41:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777303002/1
6 years ago (2014-12-04 23:19:24 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-04 23:21:14 UTC) #11
Presubmit check for 777303002-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (110 files) (65.44s) failed
/b/depot_tools/third_party/logilab/astroid/modutils.py:520: UserWarning: Module
six was already imported from /b/depot_tools/third_party/six/__init__.py, but
/usr/local/lib/python2.7/dist-packages is being added to sys.path
  import pkg_resources
Problem importing module .svn: No module named .svn
Problem importing module .svn: No module named .svn
************* Module fix_encoding
E:232, 0: Slice index is not an int, None, or instance with __index__
(invalid-slice-index)
************* Module gclient_scm
E:301,18: No value for argument 'print_func' in constructor call
(no-value-for-parameter)
E:1191,18: No value for argument 'print_func' in constructor call
(no-value-for-parameter)


post-dcommit-hook-test.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/post-dcommit-hook-test.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: dcommitted code
Using 50% similarity for rename/copy detection. Override with --similarity.
Description:
dcommit
TESTING: post-cl-dcommit hook executed
FAILURE: post-cl-dcommit hook executed


Presubmit checks took 104.9s to calculate.

Powered by Google App Engine
This is Rietveld 408576698