Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 777243002: When generating code for ia32, make sure that there is enough reloc space (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

When generating code for ia32, make sure that there is enough reloc space Compare with LCodeGen::FinishCode BUG=none R=jarin@chromium.org,mstarzinger@chromium.org LOG=n

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/code-generator.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 1 1 chunk +2 lines, -0 lines 2 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
jochen (gone - plz use gerrit)
6 years ago (2014-12-04 15:14:11 UTC) #1
titzer
https://codereview.chromium.org/777243002/diff/1/src/compiler/code-generator.cc File src/compiler/code-generator.cc (right): https://codereview.chromium.org/777243002/diff/1/src/compiler/code-generator.cc#newcode110 src/compiler/code-generator.cc:110: #if V8_TARGET_ARCH_IA32 Please, no.
6 years ago (2014-12-04 16:29:04 UTC) #3
jochen (gone - plz use gerrit)
here's a link to the DCHECK failure I was trying to fix: http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nosnap_rel/builds/1270/steps/Check/logs/stdio
6 years ago (2014-12-04 16:36:53 UTC) #4
jochen (gone - plz use gerrit)
for cctest/test-run-inlining/SimpleInliningContextDeopt
6 years ago (2014-12-04 16:37:32 UTC) #5
jochen (gone - plz use gerrit)
ptal
6 years ago (2014-12-05 08:59:14 UTC) #6
titzer
https://codereview.chromium.org/777243002/diff/20001/src/compiler/code-generator.cc File src/compiler/code-generator.cc (right): https://codereview.chromium.org/777243002/diff/20001/src/compiler/code-generator.cc#newcode110 src/compiler/code-generator.cc:110: EnsureRelocSpaceForLazyDeopt(result); Would it hurt to just do the Deoptimizer ...
6 years ago (2014-12-05 09:32:35 UTC) #7
jochen (gone - plz use gerrit)
https://codereview.chromium.org/777243002/diff/20001/src/compiler/code-generator.cc File src/compiler/code-generator.cc (right): https://codereview.chromium.org/777243002/diff/20001/src/compiler/code-generator.cc#newcode110 src/compiler/code-generator.cc:110: EnsureRelocSpaceForLazyDeopt(result); On 2014/12/05 at 09:32:35, titzer wrote: > Would ...
6 years ago (2014-12-05 09:33:35 UTC) #8
titzer
On 2014/12/05 09:33:35, jochen (slow) wrote: > https://codereview.chromium.org/777243002/diff/20001/src/compiler/code-generator.cc > File src/compiler/code-generator.cc (right): > > https://codereview.chromium.org/777243002/diff/20001/src/compiler/code-generator.cc#newcode110 ...
6 years ago (2014-12-05 10:43:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777243002/20001
6 years ago (2014-12-05 10:46:58 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-05 11:15:24 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698