Issue 777233003: Revert of Optimize add/set/delete operations for string keys in Maps and Sets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 777233003: Revert of Optimize add/set/delete operations for string keys in Maps and Sets (Closed)

Created:
6 years ago by adamk

Modified:
6 years ago

Reviewers:
Dmitry Lomov (no reviews), arv (Not doing code reviews)

CC:
arv (Not doing code reviews), rossberg, v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert of Optimize add/set/delete operations for string keys in Maps and Sets (patchset #5 id:70001 of https://codereview.chromium.org/773993002/) Reason for revert: Caused test failures in mjsunit/es6/collections with --deopt-every-n-times=1 Original issue's description: > Optimize add/set/delete operations for string keys in Maps and Sets TBR=dslomov@chromium.org,arv@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -366 lines)			Patch
M	src/collection.js	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/hydrogen.h	View	1 chunk	+2 lines, -14 lines	0 comments	Download
M	src/hydrogen.cc	View	5 chunks	+38 lines, -333 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	src/runtime/runtime.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adamk

Created Revert of Optimize add/set/delete operations for string keys in Maps and Sets

6 years ago (2014-12-04 21:36:17 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777233003/1

6 years ago (2014-12-04 21:37:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages