Issue 77723004: [CSS Blending] Fix isolation for the hardware path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 77723004: [CSS Blending] Fix isolation for the hardware path. (Closed)

Created:
7 years, 1 month ago by mitica

Modified:
7 years, 1 month ago

Reviewers:
Stephen Chennney

CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[CSS Blending] Fix isolation for the hardware path. For "isolation:isolate" with accelerated elements, an ASSERT was triggered in RenderLayerCompositor::subtreeReasonsForCompositing. This was caused by errorneously including |hasIsolation| to RenderObject::CreateGroup. Also, removing the comment from the method since it is misleading. BUG=229615 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162360

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -10 lines)			Patch
M	LayoutTests/css3/compositing/isolation-isolate-simple.html	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	LayoutTests/css3/compositing/isolation-isolate-simple-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/RenderObject.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	Source/core/rendering/RenderObject.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mitica

Hi Stephen, could you please also review this? This is the last missing part of ...

7 years, 1 month ago (2013-11-20 08:54:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mitica@adobe.com/77723004/1

7 years, 1 month ago (2013-11-20 12:27:08 UTC) #3

Message was sent while issue was closed.

Change committed as 162360

Expand Messages | Collapse Messages