Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 77723002: Remove the autosizing modes in favor of a dev site link. (Closed)

Created:
7 years, 1 month ago by pdr.
Modified:
7 years ago
Reviewers:
johnme, skobes, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Remove the autosizing modes in favor of a dev site link. Per discussion on http://crbug.com/319092, the autosizing configurations are going to be confusing to users. This change switches back to just a single "text autosizing" checkbox that emulates Chrome on Android's text autosizing behavior. This change also adds a link at the bottom of the screen emulation page for more information on the developers.google.com site. A followup patch will add help icons next to some of the checkboxes for light-weight contextual information. Preview screenshot: http://pr.gg/devsitelink.png BUG=319092 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163062

Patch Set 1 #

Total comments: 1

Patch Set 2 : Switch to a page-level wiki link instead of a learn more link. #

Patch Set 3 : Minor rename #

Total comments: 1

Patch Set 4 : Rebase, address reviewer comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -84 lines) Patch
M Source/devtools/front_end/OverridesSupport.js View 1 2 3 6 chunks +13 lines, -24 lines 0 comments Download
M Source/devtools/front_end/OverridesView.js View 1 2 3 6 chunks +51 lines, -60 lines 0 comments Download
M Source/devtools/front_end/overrides.css View 1 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pdr.
7 years, 1 month ago (2013-11-20 07:10:09 UTC) #1
skobes
lgtm https://codereview.chromium.org/77723002/diff/1/Source/devtools/front_end/OverridesSupport.js File Source/devtools/front_end/OverridesSupport.js (right): https://codereview.chromium.org/77723002/diff/1/Source/devtools/front_end/OverridesSupport.js#newcode200 Source/devtools/front_end/OverridesSupport.js:200: * Chromium on mobile uses a device scale ...
7 years, 1 month ago (2013-11-20 20:06:41 UTC) #2
pdr.
Updated! PTAL Questions for reviewers: 1) Do you like the plan of adding a link ...
7 years, 1 month ago (2013-11-21 06:40:42 UTC) #3
skobes
> 1) Do you like the plan of adding a link to the dev site ...
7 years, 1 month ago (2013-11-21 19:33:48 UTC) #4
pdr.
@pfeldman, @johnme, may I have your opinion of this patch?
7 years ago (2013-11-25 03:57:14 UTC) #5
pfeldman
red patches always lgtm!
7 years ago (2013-11-26 16:21:07 UTC) #6
johnme
> 1) Do you like the plan of adding a link to the dev site ...
7 years ago (2013-11-26 16:41:20 UTC) #7
johnme
https://codereview.chromium.org/77723002/diff/70002/Source/devtools/front_end/OverridesView.js File Source/devtools/front_end/OverridesView.js (right): https://codereview.chromium.org/77723002/diff/70002/Source/devtools/front_end/OverridesView.js#newcode264 Source/devtools/front_end/OverridesView.js:264: // - use text autosizing. While you're editing this, ...
7 years ago (2013-11-26 16:41:26 UTC) #8
pdr.
On 2013/11/26 16:41:26, johnme wrote: > https://codereview.chromium.org/77723002/diff/70002/Source/devtools/front_end/OverridesView.js > File Source/devtools/front_end/OverridesView.js (right): > > https://codereview.chromium.org/77723002/diff/70002/Source/devtools/front_end/OverridesView.js#newcode264 > ...
7 years ago (2013-12-03 03:34:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/77723002/160001
7 years ago (2013-12-03 03:34:36 UTC) #10
commit-bot: I haz the power
7 years ago (2013-12-03 05:48:08 UTC) #11
Message was sent while issue was closed.
Change committed as 163062

Powered by Google App Engine
This is Rietveld 408576698