Fix for InspectorOverlay violating document lifecycle expectations

Source/core/inspector/InspectorOverlay.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 327 matching lines @@
 InspectorOverlay::InspectorOverlay(Page* page, InspectorClient* client)
     : m_page(page)
     , m_client(client)
     , m_inspectModeEnabled(false)
     , m_overlayHost(InspectorOverlayHost::create())
     , m_drawViewSize(false)
     , m_drawViewSizeWithGrid(false)
     , m_omitTooltip(false)
     , m_timer(this, &InspectorOverlay::onTimer)
     , m_activeProfilerCount(0)
+    , m_updating(false)
 {
 }
 
 InspectorOverlay::~InspectorOverlay()
 {
     ASSERT(!m_overlayPage);
 }
 
 void InspectorOverlay::paint(GraphicsContext& context)
 {
     if (isEmpty())
         return;
     GraphicsContextStateSaver stateSaver(context);
     FrameView* view = toLocalFrame(overlayPage()->mainFrame())->view();
     ASSERT(!view->needsLayout());
     view->paint(&context, IntRect(0, 0, view->width(), view->height()));
 }
 
 void InspectorOverlay::invalidate()
 {
+    // Don't invalidate during an update, because that will lead to Document::scheduleRenderTreeUpdate
+    // being called within Document::updateRenderTree which violates document lifecycle expectations.
+    if (m_updating)
+        return;
+
     m_client->highlight();
 }
 
 bool InspectorOverlay::handleGestureEvent(const PlatformGestureEvent& event)
 {
     if (isEmpty())
         return false;
 
     return toLocalFrame(overlayPage()->mainFrame())->eventHandler().handleGestureEvent(event);
 }
@@ skipping 92 matching lines @@
 {
     if (m_activeProfilerCount)
         return true;
     bool hasAlwaysVisibleElements = m_highlightNode || m_eventTargetNode || m_highlightQuad  || m_drawViewSize;
     bool hasInvisibleInInspectModeElements = !m_pausedInDebuggerMessage.isNull();
     return !(hasAlwaysVisibleElements || (hasInvisibleInInspectModeElements && !m_inspectModeEnabled));
 }
 
 void InspectorOverlay::update()
 {
+    TemporaryChange<bool> scoped(m_updating, true);
+
     if (isEmpty()) {
         m_client->hideHighlight();
         return;
     }
 
     FrameView* view = m_page->deprecatedLocalMainFrame()->view();
     if (!view)
         return;
 
     // Include scrollbars to avoid masking them by the gutter.
@@ skipping 380 matching lines @@
     hideHighlight();
 }
 
 void InspectorOverlay::startedRecordingProfile()
 {
     if (!m_activeProfilerCount++)
         freePage();
 }
 
 } // namespace blink