Upstream iOS web API.

Upstream iOS web API.

This CL upstreams NavigationManager, WebState and
WebStateUserData to match the downstream code.

Committed: https://crrev.com/5662df670706ad5b29689b809005f7c985b18d20
Cr-Commit-Position: refs/heads/master@{#307218}

[droger, 2014-12-04 12:16:16]

droger@chromium.org changed reviewers:
+ stuartmorgan@chromium.org

[droger, 2014-12-04 12:16:17]

Stuart as OWNER
CC sdefresne

[droger, 2014-12-04 12:36:25]

Patchset #2 (id:20001) has been deleted

[stuartmorgan, 2014-12-04 23:11:44]

LGTM. These both actually belong in ios/web/public/, but we can move them
post-upstreaming rather than pre. (It'll be slightly harder since it'll be
two-sided, but not terrible.)

https://codereview.chromium.org/777183002/diff/1/ios/public/provider/web/web_...
File ios/public/provider/web/web_state.h (right):

https://codereview.chromium.org/777183002/diff/1/ios/public/provider/web/web_...
ios/public/provider/web/web_state.h:122: friend class web::WebStateObserver;
Can we upstream this header yet? It's odd to have references to it without it
existing, so we should fix that ASAP.

[stuartmorgan, 2014-12-04 23:14:12]

https://codereview.chromium.org/777183002/diff/1/ios/public/provider/web/web_...
File ios/public/provider/web/web_state.h (right):

https://codereview.chromium.org/777183002/diff/1/ios/public/provider/web/web_...
ios/public/provider/web/web_state.h:122: friend class web::WebStateObserver;
On 2014/12/04 23:11:43, stuartmorgan wrote:
> Can we upstream this header yet? It's odd to have references to it without it
> existing, so we should fix that ASAP.

Nm, I see it's in the next CL.

[droger, 2014-12-05 08:52:33]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2014-12-05 08:53:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/777183002/1

[commit-bot: I haz the power, 2014-12-05 08:56:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-05 08:56:30]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[droger, 2014-12-05 14:24:28]

I'm moving the files downstream:
https://chromereviews.googleplex.com/122457013

I'll update this CL once it is done.

[droger, 2014-12-05 15:28:30]

I updated the CL to upstream the files to web.

Please take another look, since this is now different.
In particular I removed the ios_provider_web.gyp file.

[sdefresne, 2014-12-05 15:32:50]

sdefresne@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2014-12-05 15:32:51]

LGTM

https://codereview.chromium.org/777183002/diff/60001/ios/web/public/web_state...
File ios/web/public/web_state/web_state_user_data.h (left):

https://codereview.chromium.org/777183002/diff/60001/ios/web/public/web_state...
ios/web/public/web_state/web_state_user_data.h:22: //   explicit
Foo(ios::WebState* web_state);
Same here, web::WebState.

https://codereview.chromium.org/777183002/diff/60001/ios/web/public/web_state...
ios/web/public/web_state/web_state_user_data.h:23: //   friend class
ios::WebStateUserData<Foo>;
Same here, web::WebState.

https://codereview.chromium.org/777183002/diff/60001/ios/web/public/web_state...
File ios/web/public/web_state/web_state_user_data.h (right):

https://codereview.chromium.org/777183002/diff/60001/ios/web/public/web_state...
ios/web/public/web_state/web_state_user_data.h:17: // class Foo : public
WebStateUserData<Foo> {
Please keep this as "// class Foo : public web::WebStateUserData<Foo> {" since
client code will probably not be in web namespace.

[droger, 2014-12-05 15:46:32]

On 2014/12/05 15:32:51, sdefresne wrote:
> LGTM
> 
>
https://codereview.chromium.org/777183002/diff/60001/ios/web/public/web_state...
> File ios/web/public/web_state/web_state_user_data.h (left):
> 
>
https://codereview.chromium.org/777183002/diff/60001/ios/web/public/web_state...
> ios/web/public/web_state/web_state_user_data.h:22: //   explicit
> Foo(ios::WebState* web_state);
> Same here, web::WebState.
> 
>
https://codereview.chromium.org/777183002/diff/60001/ios/web/public/web_state...
> ios/web/public/web_state/web_state_user_data.h:23: //   friend class
> ios::WebStateUserData<Foo>;
> Same here, web::WebState.
> 
>
https://codereview.chromium.org/777183002/diff/60001/ios/web/public/web_state...
> File ios/web/public/web_state/web_state_user_data.h (right):
> 
>
https://codereview.chromium.org/777183002/diff/60001/ios/web/public/web_state...
> ios/web/public/web_state/web_state_user_data.h:17: // class Foo : public
> WebStateUserData<Foo> {
> Please keep this as "// class Foo : public web::WebStateUserData<Foo> {" since
> client code will probably not be in web namespace.

Done.

[stuartmorgan, 2014-12-05 17:09:04]

lgtm

[droger, 2014-12-08 08:27:26]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2014-12-08 08:28:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/777183002/80001

[commit-bot: I haz the power, 2014-12-08 08:31:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-08 08:31:34]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[droger, 2014-12-08 08:46:36]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2014-12-08 08:47:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/777183002/100001

[commit-bot: I haz the power, 2014-12-08 10:44:30]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2014-12-08 10:45:12]

Patchset 5 (id:??) landed as
https://crrev.com/5662df670706ad5b29689b809005f7c985b18d20
Cr-Commit-Position: refs/heads/master@{#307218}