src/compiler/x64/code-generator-x64.cc - Issue 777173002: [x64] check sahf correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/code-generator-x64.cc

Issue 777173002: [x64] check sahf correctly (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x64/code-generator-x64.cc

diff --git a/src/compiler/x64/code-generator-x64.cc b/src/compiler/x64/code-generator-x64.cc

index 95cd3af6b390be05312e24b6912c429a920620eb..4a96fe866bf2b1ee442f33d6ffab8ef294a4391a 100644

--- a/src/compiler/x64/code-generator-x64.cc

+++ b/src/compiler/x64/code-generator-x64.cc

@@ -502,7 +502,8 @@ void CodeGenerator::AssembleArchInstruction(Instruction* instr) {

__ fprem();

// The following 2 instruction implicitly use rax.

__ fnstsw_ax();

- if (CpuFeatures::IsSupported(SAHF) && masm()->IsEnabled(SAHF)) {

+ if (CpuFeatures::IsSupported(SAHF)) {

+ CpuFeatureScope sahf_scope(masm(), SAHF);

__ sahf();

} else {

__ shrl(rax, Immediate(8));

« no previous file with comments | « no previous file | no next file » | no next file with comments »