Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2580)

Unified Diff: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: alexei & peter nits Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
index 776de7045dea6d190713d698fd3029e0823c9bf5..bd17ee80e8e387222075565d4a3c3e96605ee271 100644
--- a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
@@ -17,6 +17,7 @@
#include "chrome/browser/signin/signin_promo.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/chrome_pages.h"
#include "chrome/browser/ui/singleton_tabs.h"
#include "chrome/browser/ui/sync/sync_promo_ui.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
@@ -241,20 +242,19 @@ class InstalledBubbleContent : public views::View,
// Implements the views::LinkListener interface.
void LinkClicked(views::Link* source, int event_flags) override {
GetWidget()->Close();
- std::string configure_url;
- if (source == manage_shortcut_) {
- configure_url = chrome::kChromeUIExtensionsURL;
- configure_url += chrome::kExtensionConfigureCommandsSubPage;
- } else if (source == sign_in_link_) {
- configure_url = signin::GetPromoURL(
- signin::SOURCE_EXTENSION_INSTALL_BUBBLE, false).spec();
- } else {
- NOTREACHED();
+
+ if (source == sign_in_link_) {
+ chrome::ShowBrowserSignin(browser_,
+ signin::SOURCE_EXTENSION_INSTALL_BUBBLE);
return;
}
- chrome::NavigateParams params(
- chrome::GetSingletonTabNavigateParams(
- browser_, GURL(configure_url.c_str())));
+
+ DCHECK_EQ(manage_shortcut_, source);
+
+ std::string configure_url = chrome::kChromeUIExtensionsURL;
+ configure_url += chrome::kExtensionConfigureCommandsSubPage;
+ chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams(
+ browser_, GURL(configure_url)));
chrome::Navigate(&params);
}

Powered by Google App Engine
This is Rietveld 408576698