chrome/browser/signin/signin_global_error.cc - Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_global_error.cc

Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: alexei & peter nits Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/signin/signin_global_error.cc

diff --git a/chrome/browser/signin/signin_global_error.cc b/chrome/browser/signin/signin_global_error.cc

index 5f1174fc6e0b9c792d276babd3ce0ce99160e995..6ff0dc5b06e7c88960f143ea9dd718132dbb45cb 100644

--- a/chrome/browser/signin/signin_global_error.cc

+++ b/chrome/browser/signin/signin_global_error.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/signin/signin_global_error.h"

#include "base/logging.h"

+#include "base/metrics/histogram_macros.h"

#include "chrome/app/chrome_command_ids.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/signin/signin_header_helper.h"

@@ -27,6 +28,7 @@

#if !defined(OS_ANDROID) && !defined(OS_IOS)

#include "chrome/browser/signin/signin_promo.h"

+#include "chrome/browser/ui/sync/signin_histogram.h"

#endif

SigninGlobalError::SigninGlobalError(

@@ -101,6 +103,9 @@ void SigninGlobalError::ExecuteMenuItem(Browser* browser) {

return;

}

+ UMA_HISTOGRAM_ENUMERATION("Signin.Reauth",

+ signin::HISTOGRAM_SHOWN,

+ signin::HISTOGRAM_MAX);

if (switches::IsNewAvatarMenu()) {

browser->window()->ShowAvatarBubbleFromAvatarButton(

BrowserWindow::AVATAR_BUBBLE_MODE_REAUTH,

« no previous file with comments | « chrome/browser/profiles/profile_metrics.cc ('k') | chrome/browser/ui/chrome_pages.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')