Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1958)

Unified Diff: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/sync/signin_histogram.h ('k') | chrome/browser/ui/views/profiles/profile_chooser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
index 26e423683c2ed60df874f13d3dda5b13296eec96..4588409aeb9ed596a558a7006f7a7eed9fb2a719 100644
--- a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
@@ -17,6 +17,7 @@
#include "chrome/browser/signin/signin_promo.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/chrome_pages.h"
#include "chrome/browser/ui/singleton_tabs.h"
#include "chrome/browser/ui/sync/sync_promo_ui.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
@@ -307,20 +308,19 @@ void InstalledBubbleContent::ButtonPressed(views::Button* sender,
void InstalledBubbleContent::LinkClicked(views::Link* source, int event_flags) {
GetWidget()->Close();
- std::string configure_url;
- if (source == manage_shortcut_) {
- configure_url = chrome::kChromeUIExtensionsURL;
- configure_url += chrome::kExtensionConfigureCommandsSubPage;
- } else if (source == sign_in_link_) {
- configure_url = signin::GetPromoURL(
- signin::SOURCE_EXTENSION_INSTALL_BUBBLE, false).spec();
- } else {
- NOTREACHED();
+
+ if (source == sign_in_link_) {
+ chrome::ShowBrowserSignin(
+ browser_, signin_metrics::SOURCE_EXTENSION_INSTALL_BUBBLE);
return;
}
- chrome::NavigateParams params(
- chrome::GetSingletonTabNavigateParams(
- browser_, GURL(configure_url.c_str())));
+
+ DCHECK_EQ(manage_shortcut_, source);
+
+ std::string configure_url = chrome::kChromeUIExtensionsURL;
+ configure_url += chrome::kExtensionConfigureCommandsSubPage;
+ chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams(
+ browser_, GURL(configure_url)));
chrome::Navigate(&params);
}
« no previous file with comments | « chrome/browser/ui/sync/signin_histogram.h ('k') | chrome/browser/ui/views/profiles/profile_chooser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698