chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm - Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm ('k') | chrome/browser/ui/cocoa/one_click_signin_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

index 9155d879d986494e7bf098ca62001445fee10099..f5927262c799b471e9c5c14092f6ec54c8cb9e79 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

@@ -19,6 +19,7 @@

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_navigator.h"

#include "chrome/browser/ui/browser_window.h"

+#include "chrome/browser/ui/chrome_pages.h"

#include "chrome/browser/ui/chrome_style.h"

#include "chrome/browser/ui/cocoa/browser_window_cocoa.h"

#include "chrome/browser/ui/cocoa/browser_window_controller.h"

@@ -201,11 +202,8 @@ class ExtensionLoadedNotificationObserver

clickedOnLink:(id)link

atIndex:(NSUInteger)charIndex {

DCHECK_EQ(promo_.get(), aTextView);

- GURL promo_url =

- signin::GetPromoURL(signin::SOURCE_EXTENSION_INSTALL_BUBBLE, false);

- chrome::NavigateParams params(

- chrome::GetSingletonTabNavigateParams(browser_, promo_url));

- chrome::Navigate(&params);

+ chrome::ShowBrowserSignin(browser_,

+ signin_metrics::SOURCE_EXTENSION_INSTALL_BUBBLE);

return YES;

}