Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: chrome/browser/signin/signin_promo.h

Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/signin_global_error.cc ('k') | chrome/browser/signin/signin_promo.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_promo.h
diff --git a/chrome/browser/signin/signin_promo.h b/chrome/browser/signin/signin_promo.h
index 0f8937ff858eba6502e012e894d4735e65573174..de50e86ee15d07317dc2da3da574492c5ce28382 100644
--- a/chrome/browser/signin/signin_promo.h
+++ b/chrome/browser/signin/signin_promo.h
@@ -8,6 +8,7 @@
#include <string>
#include "base/basictypes.h"
+#include "components/signin/core/browser/signin_metrics.h"
class GURL;
class Profile;
@@ -26,22 +27,6 @@ const char kSignInPromoQueryKeyConstrained[] = "constrained";
const char kSignInPromoQueryKeyShowAccountManagement[] =
"showAccountManagement";
-enum Source {
- SOURCE_START_PAGE = 0, // This must be first.
- SOURCE_NTP_LINK,
- SOURCE_MENU,
- SOURCE_SETTINGS,
- SOURCE_EXTENSION_INSTALL_BUBBLE,
- SOURCE_APP_LAUNCHER,
- SOURCE_APPS_PAGE_LINK,
- SOURCE_BOOKMARK_BUBBLE,
- SOURCE_AVATAR_BUBBLE_SIGN_IN,
- SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT,
- SOURCE_DEVICES_PAGE,
- SOURCE_REAUTH,
- SOURCE_UNKNOWN, // This must be last.
-};
-
// Enum values used for Android signin promo actions.
enum AndroidSigninPromoAction {
// The promo was enabled.
@@ -85,8 +70,10 @@ GURL GetLandingURL(const char* option, int value);
// |auto_close| whether to close the sign in promo automatically when done.
// |is_constrained} whether to load the URL in a constrained window, false
// by default.
-GURL GetPromoURL(Source source, bool auto_close);
-GURL GetPromoURL(Source source, bool auto_close, bool is_constrained);
+GURL GetPromoURL(signin_metrics::Source source, bool auto_close);
+GURL GetPromoURL(signin_metrics::Source source,
+ bool auto_close,
+ bool is_constrained);
// Returns a sign in promo URL specifically for reauthenticating |account_id|.
GURL GetReauthURL(Profile* profile, const std::string& account_id);
@@ -99,7 +86,7 @@ GURL GetSigninPartitionURL();
// Gets the source from the query portion of the sign in promo URL.
// The source identifies from where the sign in promo was opened.
-Source GetSourceForPromoURL(const GURL& url);
+signin_metrics::Source GetSourceForPromoURL(const GURL& url);
// Returns true if the auto_close parameter in the given URL is set to true.
bool IsAutoCloseEnabledInURL(const GURL& url);
« no previous file with comments | « chrome/browser/signin/signin_global_error.cc ('k') | chrome/browser/signin/signin_promo.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698