Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Side by Side Diff: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/sync/one_click_signin_bubble_view.h" 5 #include "chrome/browser/ui/views/sync/one_click_signin_bubble_view.h"
6 6
7 #include "base/callback_helpers.h" 7 #include "base/callback_helpers.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/sync/one_click_signin_helper.h" 10 #include "chrome/browser/ui/sync/one_click_signin_helper.h"
11 #include "chrome/browser/ui/sync/one_click_signin_histogram.h"
12 #include "chrome/common/url_constants.h" 11 #include "chrome/common/url_constants.h"
13 #include "chrome/grit/chromium_strings.h" 12 #include "chrome/grit/chromium_strings.h"
14 #include "chrome/grit/generated_resources.h" 13 #include "chrome/grit/generated_resources.h"
15 #include "components/google/core/browser/google_util.h" 14 #include "components/google/core/browser/google_util.h"
16 #include "grit/components_strings.h" 15 #include "grit/components_strings.h"
17 #include "ui/base/l10n/l10n_util.h" 16 #include "ui/base/l10n/l10n_util.h"
18 #include "ui/base/resource/resource_bundle.h" 17 #include "ui/base/resource/resource_bundle.h"
19 #include "ui/events/keycodes/keyboard_codes.h" 18 #include "ui/events/keycodes/keyboard_codes.h"
20 #include "ui/resources/grit/ui_resources.h" 19 #include "ui/resources/grit/ui_resources.h"
21 #include "ui/views/controls/button/image_button.h" 20 #include "ui/views/controls/button/image_button.h"
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing); 202 layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing);
204 203
205 layout->StartRow(0, COLUMN_SET_CONTROLS); 204 layout->StartRow(0, COLUMN_SET_CONTROLS);
206 205
207 InitLearnMoreLink(); 206 InitLearnMoreLink();
208 layout->AddView(learn_more_link_); 207 layout->AddView(learn_more_link_);
209 } 208 }
210 209
211 void OneClickSigninBubbleView::InitDialogContent(views::GridLayout* layout) { 210 void OneClickSigninBubbleView::InitDialogContent(views::GridLayout* layout) {
212 OneClickSigninHelper::LogConfirmHistogramValue( 211 OneClickSigninHelper::LogConfirmHistogramValue(
213 one_click_signin::HISTOGRAM_CONFIRM_SHOWN); 212 signin_metrics::HISTOGRAM_CONFIRM_SHOWN);
214 213
215 // Column set for title bar. 214 // Column set for title bar.
216 views::ColumnSet* cs = layout->AddColumnSet(COLUMN_SET_TITLE_BAR); 215 views::ColumnSet* cs = layout->AddColumnSet(COLUMN_SET_TITLE_BAR);
217 cs->AddColumn(views::GridLayout::LEADING, views::GridLayout::CENTER, 0, 216 cs->AddColumn(views::GridLayout::LEADING, views::GridLayout::CENTER, 0,
218 views::GridLayout::USE_PREF, 0, 0); 217 views::GridLayout::USE_PREF, 0, 0);
219 cs->AddPaddingColumn(1, views::kUnrelatedControlHorizontalSpacing); 218 cs->AddPaddingColumn(1, views::kUnrelatedControlHorizontalSpacing);
220 cs->AddColumn(views::GridLayout::TRAILING, views::GridLayout::CENTER, 0, 219 cs->AddColumn(views::GridLayout::TRAILING, views::GridLayout::CENTER, 0,
221 views::GridLayout::USE_PREF, 0, 0); 220 views::GridLayout::USE_PREF, 0, 0);
222 221
223 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); 222 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 bool OneClickSigninBubbleView::AcceleratorPressed( 314 bool OneClickSigninBubbleView::AcceleratorPressed(
316 const ui::Accelerator& accelerator) { 315 const ui::Accelerator& accelerator) {
317 if (accelerator.key_code() == ui::VKEY_RETURN || 316 if (accelerator.key_code() == ui::VKEY_RETURN ||
318 accelerator.key_code() == ui::VKEY_ESCAPE) { 317 accelerator.key_code() == ui::VKEY_ESCAPE) {
319 OneClickSigninBubbleView::Hide(); 318 OneClickSigninBubbleView::Hide();
320 319
321 if (is_sync_dialog_) { 320 if (is_sync_dialog_) {
322 if (accelerator.key_code() == ui::VKEY_RETURN) { 321 if (accelerator.key_code() == ui::VKEY_RETURN) {
323 OneClickSigninHelper::LogConfirmHistogramValue( 322 OneClickSigninHelper::LogConfirmHistogramValue(
324 clicked_learn_more_ ? 323 clicked_learn_more_ ?
325 one_click_signin::HISTOGRAM_CONFIRM_LEARN_MORE_RETURN : 324 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_RETURN :
326 one_click_signin::HISTOGRAM_CONFIRM_RETURN); 325 signin_metrics::HISTOGRAM_CONFIRM_RETURN);
327 326
328 base::ResetAndReturn(&start_sync_callback_).Run( 327 base::ResetAndReturn(&start_sync_callback_).Run(
329 OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS); 328 OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS);
330 } else if (accelerator.key_code() == ui::VKEY_ESCAPE) { 329 } else if (accelerator.key_code() == ui::VKEY_ESCAPE) {
331 OneClickSigninHelper::LogConfirmHistogramValue( 330 OneClickSigninHelper::LogConfirmHistogramValue(
332 clicked_learn_more_ ? 331 clicked_learn_more_ ?
333 one_click_signin::HISTOGRAM_CONFIRM_LEARN_MORE_ESCAPE : 332 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_ESCAPE :
334 one_click_signin::HISTOGRAM_CONFIRM_ESCAPE); 333 signin_metrics::HISTOGRAM_CONFIRM_ESCAPE);
335 334
336 base::ResetAndReturn(&start_sync_callback_).Run( 335 base::ResetAndReturn(&start_sync_callback_).Run(
337 OneClickSigninSyncStarter::UNDO_SYNC); 336 OneClickSigninSyncStarter::UNDO_SYNC);
338 } 337 }
339 } 338 }
340 339
341 return true; 340 return true;
342 } 341 }
343 342
344 return BubbleDelegateView::AcceleratorPressed(accelerator); 343 return BubbleDelegateView::AcceleratorPressed(accelerator);
345 } 344 }
346 345
347 void OneClickSigninBubbleView::LinkClicked(views::Link* source, 346 void OneClickSigninBubbleView::LinkClicked(views::Link* source,
348 int event_flags) { 347 int event_flags) {
349 if (source == learn_more_link_) { 348 if (source == learn_more_link_) {
350 if (is_sync_dialog_ && !clicked_learn_more_) { 349 if (is_sync_dialog_ && !clicked_learn_more_) {
351 OneClickSigninHelper::LogConfirmHistogramValue( 350 OneClickSigninHelper::LogConfirmHistogramValue(
352 one_click_signin::HISTOGRAM_CONFIRM_LEARN_MORE); 351 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE);
353 clicked_learn_more_ = true; 352 clicked_learn_more_ = true;
354 } 353 }
355 delegate_->OnLearnMoreLinkClicked(is_sync_dialog_); 354 delegate_->OnLearnMoreLinkClicked(is_sync_dialog_);
356 355
357 // don't hide the modal dialog, as this is an informational link 356 // don't hide the modal dialog, as this is an informational link
358 if (is_sync_dialog_) 357 if (is_sync_dialog_)
359 return; 358 return;
360 } else if (advanced_link_ && source == advanced_link_) { 359 } else if (advanced_link_ && source == advanced_link_) {
361 if (is_sync_dialog_) { 360 if (is_sync_dialog_) {
362 OneClickSigninHelper::LogConfirmHistogramValue( 361 OneClickSigninHelper::LogConfirmHistogramValue(
363 clicked_learn_more_ ? 362 clicked_learn_more_ ?
364 one_click_signin::HISTOGRAM_CONFIRM_LEARN_MORE_ADVANCED : 363 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_ADVANCED :
365 one_click_signin::HISTOGRAM_CONFIRM_ADVANCED); 364 signin_metrics::HISTOGRAM_CONFIRM_ADVANCED);
366 365
367 base::ResetAndReturn(&start_sync_callback_).Run( 366 base::ResetAndReturn(&start_sync_callback_).Run(
368 OneClickSigninSyncStarter::CONFIGURE_SYNC_FIRST); 367 OneClickSigninSyncStarter::CONFIGURE_SYNC_FIRST);
369 } else { 368 } else {
370 delegate_->OnAdvancedLinkClicked(); 369 delegate_->OnAdvancedLinkClicked();
371 } 370 }
372 } 371 }
373 372
374 Hide(); 373 Hide();
375 } 374 }
376 375
377 void OneClickSigninBubbleView::ButtonPressed(views::Button* sender, 376 void OneClickSigninBubbleView::ButtonPressed(views::Button* sender,
378 const ui::Event& event) { 377 const ui::Event& event) {
379 Hide(); 378 Hide();
380 379
381 if (is_sync_dialog_) { 380 if (is_sync_dialog_) {
382 if (sender == ok_button_) 381 if (sender == ok_button_)
383 OneClickSigninHelper::LogConfirmHistogramValue( 382 OneClickSigninHelper::LogConfirmHistogramValue(
384 clicked_learn_more_ ? 383 clicked_learn_more_ ?
385 one_click_signin::HISTOGRAM_CONFIRM_LEARN_MORE_OK : 384 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_OK :
386 one_click_signin::HISTOGRAM_CONFIRM_OK); 385 signin_metrics::HISTOGRAM_CONFIRM_OK);
387 386
388 if (sender == undo_button_) 387 if (sender == undo_button_)
389 OneClickSigninHelper::LogConfirmHistogramValue( 388 OneClickSigninHelper::LogConfirmHistogramValue(
390 clicked_learn_more_ ? 389 clicked_learn_more_ ?
391 one_click_signin::HISTOGRAM_CONFIRM_LEARN_MORE_UNDO : 390 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_UNDO :
392 one_click_signin::HISTOGRAM_CONFIRM_UNDO); 391 signin_metrics::HISTOGRAM_CONFIRM_UNDO);
393 392
394 if (sender == close_button_) 393 if (sender == close_button_)
395 OneClickSigninHelper::LogConfirmHistogramValue( 394 OneClickSigninHelper::LogConfirmHistogramValue(
396 clicked_learn_more_ ? 395 clicked_learn_more_ ?
397 one_click_signin::HISTOGRAM_CONFIRM_LEARN_MORE_CLOSE : 396 signin_metrics::HISTOGRAM_CONFIRM_LEARN_MORE_CLOSE :
398 one_click_signin::HISTOGRAM_CONFIRM_CLOSE); 397 signin_metrics::HISTOGRAM_CONFIRM_CLOSE);
399 398
400 base::ResetAndReturn(&start_sync_callback_).Run((sender == ok_button_) ? 399 base::ResetAndReturn(&start_sync_callback_).Run((sender == ok_button_) ?
401 OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS : 400 OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS :
402 OneClickSigninSyncStarter::UNDO_SYNC); 401 OneClickSigninSyncStarter::UNDO_SYNC);
403 } 402 }
404 } 403 }
405 404
406 void OneClickSigninBubbleView::WindowClosing() { 405 void OneClickSigninBubbleView::WindowClosing() {
407 // We have to reset |bubble_view_| here, not in our destructor, because 406 // We have to reset |bubble_view_| here, not in our destructor, because
408 // we'll be destroyed asynchronously and the shown state will be checked 407 // we'll be destroyed asynchronously and the shown state will be checked
409 // before then. 408 // before then.
410 DCHECK_EQ(bubble_view_, this); 409 DCHECK_EQ(bubble_view_, this);
411 bubble_view_ = NULL; 410 bubble_view_ = NULL;
412 411
413 if (is_sync_dialog_ && !start_sync_callback_.is_null()) { 412 if (is_sync_dialog_ && !start_sync_callback_.is_null()) {
414 base::ResetAndReturn(&start_sync_callback_).Run( 413 base::ResetAndReturn(&start_sync_callback_).Run(
415 OneClickSigninSyncStarter::UNDO_SYNC); 414 OneClickSigninSyncStarter::UNDO_SYNC);
416 } 415 }
417 } 416 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698