Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: chrome/browser/signin/signin_browsertest.cc

Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SIGNIN_SIGNIN_BROWSERTEST_H_ 5 #ifndef CHROME_BROWSER_SIGNIN_SIGNIN_BROWSERTEST_H_
6 #define CHROME_BROWSER_SIGNIN_SIGNIN_BROWSERTEST_H_ 6 #define CHROME_BROWSER_SIGNIN_SIGNIN_BROWSERTEST_H_
7 7
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "chrome/browser/signin/chrome_signin_client.h" 9 #include "chrome/browser/signin/chrome_signin_client.h"
10 #include "chrome/browser/signin/chrome_signin_client_factory.h" 10 #include "chrome/browser/signin/chrome_signin_client_factory.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 #define MAYBE_ProcessIsolation DISABLED_ProcessIsolation 105 #define MAYBE_ProcessIsolation DISABLED_ProcessIsolation
106 #else 106 #else
107 #define MAYBE_ProcessIsolation ProcessIsolation 107 #define MAYBE_ProcessIsolation ProcessIsolation
108 #endif 108 #endif
109 IN_PROC_BROWSER_TEST_F(SigninBrowserTest, MAYBE_ProcessIsolation) { 109 IN_PROC_BROWSER_TEST_F(SigninBrowserTest, MAYBE_ProcessIsolation) {
110 SigninClient* signin = 110 SigninClient* signin =
111 ChromeSigninClientFactory::GetForProfile(browser()->profile()); 111 ChromeSigninClientFactory::GetForProfile(browser()->profile());
112 EXPECT_FALSE(signin->HasSigninProcess()); 112 EXPECT_FALSE(signin->HasSigninProcess());
113 113
114 ui_test_utils::NavigateToURL(browser(), signin::GetPromoURL( 114 ui_test_utils::NavigateToURL(browser(), signin::GetPromoURL(
115 signin::SOURCE_NTP_LINK, true)); 115 signin_metrics::SOURCE_NTP_LINK, true));
116 EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess()); 116 EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess());
117 117
118 // Navigating away should change the process. 118 // Navigating away should change the process.
119 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIOmniboxURL)); 119 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIOmniboxURL));
120 EXPECT_FALSE(signin->HasSigninProcess()); 120 EXPECT_FALSE(signin->HasSigninProcess());
121 121
122 ui_test_utils::NavigateToURL(browser(), signin::GetPromoURL( 122 ui_test_utils::NavigateToURL(browser(), signin::GetPromoURL(
123 signin::SOURCE_NTP_LINK, true)); 123 signin_metrics::SOURCE_NTP_LINK, true));
124 EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess()); 124 EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess());
125 125
126 content::WebContents* active_tab = 126 content::WebContents* active_tab =
127 browser()->tab_strip_model()->GetActiveWebContents(); 127 browser()->tab_strip_model()->GetActiveWebContents();
128 int active_tab_process_id = 128 int active_tab_process_id =
129 active_tab->GetRenderProcessHost()->GetID(); 129 active_tab->GetRenderProcessHost()->GetID();
130 EXPECT_EQ(kOneClickSigninEnabled, 130 EXPECT_EQ(kOneClickSigninEnabled,
131 signin->IsSigninProcess(active_tab_process_id)); 131 signin->IsSigninProcess(active_tab_process_id));
132 EXPECT_EQ(0, active_tab->GetRenderViewHost()->GetEnabledBindings()); 132 EXPECT_EQ(0, active_tab->GetRenderViewHost()->GetEnabledBindings());
133 133
134 // Entry points to signin request "SINGLETON_TAB" mode, so a new request 134 // Entry points to signin request "SINGLETON_TAB" mode, so a new request
135 // shouldn't change anything. 135 // shouldn't change anything.
136 chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams( 136 chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams(
137 browser(), 137 browser(),
138 GURL(signin::GetPromoURL(signin::SOURCE_NTP_LINK, false)))); 138 GURL(signin::GetPromoURL(signin_metrics::SOURCE_NTP_LINK, false))));
139 params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE; 139 params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE;
140 ShowSingletonTabOverwritingNTP(browser(), params); 140 ShowSingletonTabOverwritingNTP(browser(), params);
141 EXPECT_EQ(active_tab, browser()->tab_strip_model()->GetActiveWebContents()); 141 EXPECT_EQ(active_tab, browser()->tab_strip_model()->GetActiveWebContents());
142 EXPECT_EQ(kOneClickSigninEnabled, 142 EXPECT_EQ(kOneClickSigninEnabled,
143 signin->IsSigninProcess(active_tab_process_id)); 143 signin->IsSigninProcess(active_tab_process_id));
144 144
145 // Navigating away should change the process. 145 // Navigating away should change the process.
146 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUINewTabURL)); 146 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUINewTabURL));
147 EXPECT_FALSE(signin->IsSigninProcess( 147 EXPECT_FALSE(signin->IsSigninProcess(
148 active_tab->GetRenderProcessHost()->GetID())); 148 active_tab->GetRenderProcessHost()->GetID()));
149 } 149 }
150 150
151 #if defined (OS_MACOSX) 151 #if defined (OS_MACOSX)
152 // crbug.com/375197 152 // crbug.com/375197
153 #define MAYBE_NotTrustedAfterRedirect DISABLED_NotTrustedAfterRedirect 153 #define MAYBE_NotTrustedAfterRedirect DISABLED_NotTrustedAfterRedirect
154 #else 154 #else
155 #define MAYBE_NotTrustedAfterRedirect NotTrustedAfterRedirect 155 #define MAYBE_NotTrustedAfterRedirect NotTrustedAfterRedirect
156 #endif 156 #endif
157 157
158 IN_PROC_BROWSER_TEST_F(SigninBrowserTest, MAYBE_NotTrustedAfterRedirect) { 158 IN_PROC_BROWSER_TEST_F(SigninBrowserTest, MAYBE_NotTrustedAfterRedirect) {
159 SigninClient* signin = 159 SigninClient* signin =
160 ChromeSigninClientFactory::GetForProfile(browser()->profile()); 160 ChromeSigninClientFactory::GetForProfile(browser()->profile());
161 EXPECT_FALSE(signin->HasSigninProcess()); 161 EXPECT_FALSE(signin->HasSigninProcess());
162 162
163 GURL url = signin::GetPromoURL(signin::SOURCE_NTP_LINK, true); 163 GURL url = signin::GetPromoURL(signin_metrics::SOURCE_NTP_LINK, true);
164 ui_test_utils::NavigateToURL(browser(), url); 164 ui_test_utils::NavigateToURL(browser(), url);
165 EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess()); 165 EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess());
166 166
167 // Navigating in a different tab should not affect the sign-in process. 167 // Navigating in a different tab should not affect the sign-in process.
168 ui_test_utils::NavigateToURLWithDisposition( 168 ui_test_utils::NavigateToURLWithDisposition(
169 browser(), GURL(kNonSigninURL), NEW_BACKGROUND_TAB, 169 browser(), GURL(kNonSigninURL), NEW_BACKGROUND_TAB,
170 ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION); 170 ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
171 EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess()); 171 EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess());
172 172
173 // Navigating away should clear the sign-in process. 173 // Navigating away should clear the sign-in process.
(...skipping 26 matching lines...) Expand all
200 private: 200 private:
201 DISALLOW_COPY_AND_ASSIGN(BackOnNTPCommitObserver); 201 DISALLOW_COPY_AND_ASSIGN(BackOnNTPCommitObserver);
202 }; 202 };
203 203
204 // This is a test for http://crbug.com/257277. It simulates the navigations 204 // This is a test for http://crbug.com/257277. It simulates the navigations
205 // that occur if the user clicks on the "Skip for now" link at the signin page 205 // that occur if the user clicks on the "Skip for now" link at the signin page
206 // and initiates a back navigation between the point of Commit and 206 // and initiates a back navigation between the point of Commit and
207 // DidStopLoading of the NTP. 207 // DidStopLoading of the NTP.
208 IN_PROC_BROWSER_TEST_F(SigninBrowserTest, SigninSkipForNowAndGoBack) { 208 IN_PROC_BROWSER_TEST_F(SigninBrowserTest, SigninSkipForNowAndGoBack) {
209 GURL ntp_url(chrome::kChromeUINewTabURL); 209 GURL ntp_url(chrome::kChromeUINewTabURL);
210 GURL start_url = signin::GetPromoURL(signin::SOURCE_START_PAGE, false); 210 GURL start_url = signin::GetPromoURL(
211 signin_metrics::SOURCE_START_PAGE, false);
211 GURL skip_url = signin::GetLandingURL("ntp", 1); 212 GURL skip_url = signin::GetLandingURL("ntp", 1);
212 213
213 SigninClient* signin = 214 SigninClient* signin =
214 ChromeSigninClientFactory::GetForProfile(browser()->profile()); 215 ChromeSigninClientFactory::GetForProfile(browser()->profile());
215 EXPECT_FALSE(signin->HasSigninProcess()); 216 EXPECT_FALSE(signin->HasSigninProcess());
216 217
217 ui_test_utils::NavigateToURL(browser(), start_url); 218 ui_test_utils::NavigateToURL(browser(), start_url);
218 EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess()); 219 EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess());
219 220
220 content::WebContents* web_contents = 221 content::WebContents* web_contents =
(...skipping 20 matching lines...) Expand all
241 EXPECT_EQ(skip_url, web_contents->GetLastCommittedURL()); 242 EXPECT_EQ(skip_url, web_contents->GetLastCommittedURL());
242 EXPECT_EQ(start_url, web_contents->GetVisibleURL()); 243 EXPECT_EQ(start_url, web_contents->GetVisibleURL());
243 244
244 content::WindowedNotificationObserver observer( 245 content::WindowedNotificationObserver observer(
245 content::NOTIFICATION_LOAD_STOP, 246 content::NOTIFICATION_LOAD_STOP,
246 content::NotificationService::AllSources()); 247 content::NotificationService::AllSources());
247 observer.Wait(); 248 observer.Wait();
248 EXPECT_EQ(start_url, web_contents->GetLastCommittedURL()); 249 EXPECT_EQ(start_url, web_contents->GetLastCommittedURL());
249 } 250 }
250 #endif // CHROME_BROWSER_SIGNIN_SIGNIN_BROWSERTEST_H_ 251 #endif // CHROME_BROWSER_SIGNIN_SIGNIN_BROWSERTEST_H_
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/ui/inline_login_dialog.cc ('k') | chrome/browser/signin/signin_global_error.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698