Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Side by Side Diff: chrome/browser/ui/sync/one_click_signin_helper.h

Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_ 5 #ifndef CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_
6 #define CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_ 6 #define CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 162
163 OneClickSigninHelper::StartSyncArgs args_; 163 OneClickSigninHelper::StartSyncArgs args_;
164 chrome::HostDesktopType desktop_type_; 164 chrome::HostDesktopType desktop_type_;
165 OneClickSigninSyncStarter::StartSyncMode start_mode_; 165 OneClickSigninSyncStarter::StartSyncMode start_mode_;
166 scoped_ptr<SigninOAuthHelper> signin_oauth_helper_; 166 scoped_ptr<SigninOAuthHelper> signin_oauth_helper_;
167 base::WeakPtrFactory<SyncStarterWrapper> weak_pointer_factory_; 167 base::WeakPtrFactory<SyncStarterWrapper> weak_pointer_factory_;
168 168
169 DISALLOW_COPY_AND_ASSIGN(SyncStarterWrapper); 169 DISALLOW_COPY_AND_ASSIGN(SyncStarterWrapper);
170 }; 170 };
171 171
172 static void LogHistogramValue(signin::Source source, int action); 172 static void LogHistogramValue(int action);
173
174 static void LogHistogramSourceValue(signin::Source source);
173 175
174 // Returns true if the one-click signin feature can be offered at this time. 176 // Returns true if the one-click signin feature can be offered at this time.
175 // If |email| is not empty, then the profile is checked to see if it's 177 // If |email| is not empty, then the profile is checked to see if it's
176 // already connected to a google account or if the user has already rejected 178 // already connected to a google account or if the user has already rejected
177 // one-click sign-in with this email, in which cases a one click signin 179 // one-click sign-in with this email, in which cases a one click signin
178 // should not be offered. 180 // should not be offered.
179 // 181 //
180 // If |can_offer_for| is |CAN_OFFER_FOR_INTERSTITAL_ONLY|, then only do the 182 // If |can_offer_for| is |CAN_OFFER_FOR_INTERSTITAL_ONLY|, then only do the
181 // checks that would affect the interstitial page. Otherwise, do the checks 183 // checks that would affect the interstitial page. Otherwise, do the checks
182 // that would affect the interstitial and the explicit sign ins. 184 // that would affect the interstitial and the explicit sign ins.
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 379
378 // Allows unittest to avoid starting sync for real. 380 // Allows unittest to avoid starting sync for real.
379 bool do_not_start_sync_for_testing_; 381 bool do_not_start_sync_for_testing_;
380 382
381 base::WeakPtrFactory<OneClickSigninHelper> weak_pointer_factory_; 383 base::WeakPtrFactory<OneClickSigninHelper> weak_pointer_factory_;
382 384
383 DISALLOW_COPY_AND_ASSIGN(OneClickSigninHelper); 385 DISALLOW_COPY_AND_ASSIGN(OneClickSigninHelper);
384 }; 386 };
385 387
386 #endif // CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_ 388 #endif // CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698