chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm - Issue 777103002: Add the names of plugins to the blocked plugin bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

Issue 777103002: Add the names of plugins to the blocked plugin bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use group_name instead of plugin.name Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/tab_specific_content_settings.cc ('k') | chrome/browser/ui/content_settings/content_setting_bubble_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm b/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

index 92ad9aa7b0ef24a4fb039664c41dc677fd30c8b0..99352b84cf7edd765fe00de578488dd4349eb0c6 100644

--- a/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

@@ -383,12 +383,9 @@ class ContentSettingBubbleWebContentsObserverBridge

}

- (void)initializeBlockedPluginsList {

- int delta = NSMinY([titleLabel_ frame]) -

- NSMinY([blockedResourcesField_ frame]);

- [blockedResourcesField_ removeFromSuperview];

- NSRect frame = [[self window] frame];

- frame.size.height -= delta;

- [[self window] setFrame:frame display:NO];

+ NSString* label = base::SysUTF16ToNSString(

+ contentSettingBubbleModel_->bubble_content().plugin_names);

+ [blockedResourcesField_ setStringValue:label];

}

- (void)initializePopupList {