Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4049)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 777103002: Add the names of plugins to the blocked plugin bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: code review comments. formatting. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/render_messages.h ('k') | chrome/renderer/content_settings_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 62fc9409f759fbef9be22531dc946884bf407b15..434fe95be0a39ebf107c7c38b6d775c961d19e5b 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -877,7 +877,7 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(
identifier));
} else {
// Send IPC for showing blocked plugins page action.
- observer->DidBlockContentType(content_type);
+ observer->DidBlockContentType(content_type, plugin.name);
Bernhard Bauer 2014/12/08 21:47:14 Could you pass |group_name| here and below instead
Will Harris 2014/12/09 07:27:09 Done.
}
break;
}
@@ -888,7 +888,7 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(
placeholder->set_allow_loading(true);
RenderThread::Get()->RecordAction(
UserMetricsAction("Plugin_ClickToPlay"));
- observer->DidBlockContentType(content_type);
+ observer->DidBlockContentType(content_type, plugin.name);
break;
}
case ChromeViewHostMsg_GetPluginInfo_Status::kBlocked: {
@@ -897,7 +897,7 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(
l10n_util::GetStringFUTF16(IDS_PLUGIN_BLOCKED, group_name), GURL());
placeholder->set_allow_loading(true);
RenderThread::Get()->RecordAction(UserMetricsAction("Plugin_Blocked"));
- observer->DidBlockContentType(content_type);
+ observer->DidBlockContentType(content_type, plugin.name);
break;
}
case ChromeViewHostMsg_GetPluginInfo_Status::kBlockedByPolicy: {
@@ -907,7 +907,7 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(
placeholder->set_allow_loading(false);
RenderThread::Get()->RecordAction(
UserMetricsAction("Plugin_BlockedByPolicy"));
- observer->DidBlockContentType(content_type);
+ observer->DidBlockContentType(content_type, plugin.name);
break;
}
}
« no previous file with comments | « chrome/common/render_messages.h ('k') | chrome/renderer/content_settings_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698