Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 776973003: Revert of Revert "[Android] Switch b/a/test_runner.py from optparse to argparse." (Closed)

Created:
6 years ago by jam
Modified:
6 years ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "[Android] Switch b/a/test_runner.py from optparse to argparse." (patchset #1 id:1 of https://codereview.chromium.org/775863004/) Reason for revert: this broke 8a9f8022215576925f29e07f0b203cd59e4183fc org.chromium.chrome.browser.omnibox.OmniboxUrlEmphasizerTest#testShortSecureHTTPSUrlWithLightColors Original issue's description: > Revert "[Android] Switch b/a/test_runner.py from optparse to argparse." > > This reverts commit 8a9f8022215576925f29e07f0b203cd59e4183fc. > > It broke tests on several bots because the list of accepted GTest suites > became restricted to those included in a certain set. > > TBR=jbudorick@chromium.org, klundberg@chromium.org > NOTRY=true > BUG=438603 > > Committed: https://crrev.com/bd4e73d47bd0914f6bb43432efa76e90750de962 > Cr-Commit-Position: refs/heads/master@{#306610} TBR=perezju@chromium.org,jbudorick@chromium.org,peter@chromium.org NOTREECHECKS=true NOTRY=true BUG=438603 Committed: https://crrev.com/a47ca85c4614c1b39b0f623157618760fda09bca Cr-Commit-Position: refs/heads/master@{#306632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+538 lines, -650 lines) Patch
M build/android/pylib/base/environment_factory.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/base/test_instance_factory.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/base/test_run_factory.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/constants.py View 1 chunk +2 lines, -0 lines 0 comments Download
M build/android/pylib/junit/setup.py View 1 chunk +4 lines, -2 lines 0 comments Download
M build/android/pylib/junit/test_runner.py View 1 chunk +6 lines, -6 lines 0 comments Download
M build/android/pylib/linker/setup.py View 2 chunks +6 lines, -4 lines 0 comments Download
M build/android/test_runner.py View 13 chunks +517 lines, -635 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
Created Revert of Revert "[Android] Switch b/a/test_runner.py from optparse to argparse."
6 years ago (2014-12-03 18:36:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776973003/1
6 years ago (2014-12-03 18:37:13 UTC) #2
jbudorick
On 2014/12/03 18:37:13, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years ago (2014-12-03 18:37:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-03 18:38:18 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-03 18:39:04 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a47ca85c4614c1b39b0f623157618760fda09bca
Cr-Commit-Position: refs/heads/master@{#306632}

Powered by Google App Engine
This is Rietveld 408576698