Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 776943004: Properly handle viewport-flings after a bubbling scroll (Closed)

Created:
6 years ago by jdduke (slow)
Modified:
6 years ago
CC:
bokan, cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Properly handle viewport-flings after a bubbling scroll A compositor-driven fling will lock to the first layer that scrolls after the fling starts. This can often be a different scrolling layer than was first scrolled, e.g., when a scrolling layer reaches its limit and the user then initiates a fling. A recent change (r304898) inadvertently prevents the fling from locking to the viewport layer after a bubbling touch scroll. Fix this by ensuring the scrolling layer is always set after the fling's first scroll animation update. BUG=439698 Committed: https://crrev.com/14ffa6bce4fe48939379ef32c304f02064efad96 Cr-Commit-Position: refs/heads/master@{#307162}

Patch Set 1 #

Patch Set 2 : Minor fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -2 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jdduke (slow)
aelias@: PTAL, thanks. Should have noticed this sooner...
6 years ago (2014-12-06 04:09:59 UTC) #2
aelias_OOO_until_Jul13
lgtm, thanks.
6 years ago (2014-12-06 04:15:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776943004/20001
6 years ago (2014-12-06 05:57:40 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-06 07:12:47 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-06 07:13:36 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/14ffa6bce4fe48939379ef32c304f02064efad96
Cr-Commit-Position: refs/heads/master@{#307162}

Powered by Google App Engine
This is Rietveld 408576698