Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 776943003: Factor painting code from RenderLayerScrollableArea into ScrollableAreaPainter (Closed)

Created:
6 years ago by chrishtr
Modified:
6 years ago
Reviewers:
pdr.
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Factor painting code from RenderLayerScrollableArea into ScrollableAreaPainter In the process, made a few methods public on RenderLayerScrollableArea. The cached control position bit makes me a little sad. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186739

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -179 lines) Patch
M Source/core/core.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/paint/BlockPainter.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/paint/LayerPainter.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/paint/PartPainter.cpp View 2 chunks +2 lines, -1 line 0 comments Download
A Source/core/paint/ScrollableAreaPainter.h View 1 chunk +32 lines, -0 lines 0 comments Download
A Source/core/paint/ScrollableAreaPainter.cpp View 2 1 chunk +181 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.h View 6 chunks +19 lines, -13 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 2 3 4 chunks +0 lines, -160 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chrishtr
6 years ago (2014-12-06 01:06:06 UTC) #2
chrishtr
ping
6 years ago (2014-12-08 18:54:13 UTC) #3
pdr.
lgtm
6 years ago (2014-12-08 23:37:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776943003/60001
6 years ago (2014-12-08 23:37:31 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-08 23:58:40 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186739

Powered by Google App Engine
This is Rietveld 408576698