Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 77693002: [DoNotCheckSecurity=Getter] => [DoNotCheckSecurity] for readonly attribute (Closed)

Created:
7 years, 1 month ago by Nils Barth (inactive)
Modified:
7 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, arv+blink, Inactive, watchdog-blink-watchlist_google.com, kouhei (in TOK)
Visibility:
Public.

Description

[DoNotCheckSecurity=Getter] => [DoNotCheckSecurity] for readonly attribute IDL cleanup. Docs updated: https://sites.google.com/a/chromium.org/dev/blink/webidl/blink-idl-extended-attributes#TOC-DoNotCheckSecurity-m-a- TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162343

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/frame/Window.idl View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nils Barth (inactive)
7 years, 1 month ago (2013-11-20 06:42:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/77693002/1
7 years, 1 month ago (2013-11-20 06:42:46 UTC) #2
haraken
LGTM Looks like it's better to clean-up the code for security checks before landing the ...
7 years, 1 month ago (2013-11-20 06:43:21 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 1 month ago (2013-11-20 07:46:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/77693002/1
7 years, 1 month ago (2013-11-20 08:14:25 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-20 08:14:39 UTC) #6
Message was sent while issue was closed.
Change committed as 162343

Powered by Google App Engine
This is Rietveld 408576698