Cleanup: Remove some unneeded string allocations.

chrome/browser/ui/find_bar/find_bar_host_interactive_uitest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/find_bar/find_bar.h"
 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
 #include "chrome/browser/ui/find_bar/find_tab_helper.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
@@ skipping 12 matching lines @@
 
 const char kEndState[] = "/find_in_page/end_state.html";
 
 class FindInPageInteractiveTest : public InProcessBrowserTest {
  public:
   FindInPageInteractiveTest() {
   }
 
   // Platform independent FindInPage that takes |const wchar_t*|
   // as an input.
-  int FindInPageWchar(WebContents* web_contents,
-                      const wchar_t* search_str,
+  int FindInPageASCII(WebContents* web_contents,
+                      const base::StringPiece& search_str,
                       bool forward,
                       bool case_sensitive,
                       int* ordinal) {
-    base::string16 search_str16(WideToUTF16(std::wstring(search_str)));
+    base::string16 search_str16(ASCIIToUTF16(search_str));
     Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
     browser->GetFindBarController()->find_bar()->SetFindTextAndSelectedRange(
         search_str16, gfx::Range());
     return ui_test_utils::FindInPage(
         web_contents, search_str16, forward, case_sensitive, ordinal, NULL);
   }
 };
 
 }  // namespace
 
@@ skipping 28 matching lines @@
   FindTabHelper* find_tab_helper =
       FindTabHelper::FromWebContents(web_contents);
 
   // Verify that nothing has focus.
   std::string result;
   ASSERT_TRUE(FocusedOnPage(web_contents, &result));
   ASSERT_STREQ("{nothing focused}", result.c_str());
 
   // Search for a text that exists within a link on the page.
   int ordinal = 0;
-  EXPECT_EQ(1, FindInPageWchar(web_contents, L"nk",
+  EXPECT_EQ(1, FindInPageASCII(web_contents, "nk",
                                true, false, &ordinal));
   EXPECT_EQ(1, ordinal);
 
   // End the find session, which should set focus to the link.
   find_tab_helper->StopFinding(FindBarController::kKeepSelectionOnPage);
 
   // Verify that the link is focused.
   ASSERT_TRUE(FocusedOnPage(web_contents, &result));
   EXPECT_STREQ("link1", result.c_str());
 
   // Search for a text that exists within a link on the page.
-  EXPECT_EQ(1, FindInPageWchar(web_contents, L"Google",
+  EXPECT_EQ(1, FindInPageASCII(web_contents, "Google",
                                true, false, &ordinal));
   EXPECT_EQ(1, ordinal);
 
   // Move the selection to link 1, after searching.
   ASSERT_TRUE(content::ExecuteScriptAndExtractString(
       web_contents,
       "window.domAutomationController.send(selectLink1());",
       &result));
 
   // End the find session.
   find_tab_helper->StopFinding(FindBarController::kKeepSelectionOnPage);
 
   // Verify that link2 is not focused.
   ASSERT_TRUE(FocusedOnPage(web_contents, &result));
   EXPECT_STREQ("", result.c_str());
 }