Cleanup: Remove some unneeded string allocations.

chrome/browser/extensions/external_pref_loader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/external_pref_loader.h"
 
 #include "base/bind.h"
 #include "base/files/file_enumerator.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
@@ skipping 24 matching lines @@
   if (!base::PathExists(external_extension_search_path)) {
     // Does not have to exist.
     return external_extension_paths;
   }
 
   base::FileEnumerator json_files(
       external_extension_search_path,
       false,  // Recursive.
       base::FileEnumerator::FILES);
 #if defined(OS_WIN)
-  base::FilePath::StringType extension = base::UTF8ToWide(std::string(".json"));
+  base::FilePath::StringType extension = base::UTF8ToWide(".json");
 #elif defined(OS_POSIX)
   base::FilePath::StringType extension(".json");
 #endif
   do {
     base::FilePath file = json_files.Next();
     if (file.BaseName().value() == kExternalExtensionJson)
       continue;  // Already taken care of elsewhere.
     if (file.empty())
       break;
     if (file.MatchesExtension(extension)) {
@@ skipping 189 matching lines @@
   for (std::set<base::FilePath>::const_iterator it = candidates.begin();
        it != candidates.end();
        ++it) {
     base::FilePath extension_candidate_path = base_path_.Append(*it);
 
     std::string id =
 #if defined(OS_WIN)
         base::UTF16ToASCII(
             extension_candidate_path.RemoveExtension().BaseName().value());
 #elif defined(OS_POSIX)
-        extension_candidate_path.RemoveExtension().BaseName().value().c_str();
+        extension_candidate_path.RemoveExtension().BaseName().value();
 #endif
 
     DVLOG(1) << "Reading json file: "
-             << extension_candidate_path.LossyDisplayName().c_str();
+             << extension_candidate_path.LossyDisplayName();
 
     JSONFileValueSerializer serializer(extension_candidate_path);
     scoped_ptr<base::DictionaryValue> ext_prefs(
         ExtractExtensionPrefs(&serializer, extension_candidate_path));
     if (ext_prefs) {
       DVLOG(1) << "Adding extension with id: " << id;
       prefs->Set(id, ext_prefs.release());
     }
   }
 }
@@ skipping 14 matching lines @@
   LoadFinished();
 }
 
 ExternalTestingLoader::~ExternalTestingLoader() {}
 
 const base::FilePath ExternalTestingLoader::GetBaseCrxFilePath() {
   return fake_base_path_;
 }
 
 }  // namespace extensions