Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1742)

Unified Diff: tools/telemetry/telemetry/benchmark.py

Issue 776883004: Basic android app implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a couple errors Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/benchmark.py
diff --git a/tools/telemetry/telemetry/benchmark.py b/tools/telemetry/telemetry/benchmark.py
index 8621a26ded1e48840c08a1dc5131d9c6348e1982..aa64a69f7aaf91962bf34d234a0e64628727f80f 100644
--- a/tools/telemetry/telemetry/benchmark.py
+++ b/tools/telemetry/telemetry/benchmark.py
@@ -185,8 +185,8 @@ class Benchmark(command_line.Command):
"""
if not hasattr(self, 'test'):
raise NotImplementedError('This test has no "test" attribute.')
- if not issubclass(self.test, page_test.PageTest):
- raise TypeError('"%s" is not a PageTest.' % self.test.__name__)
+ #if not issubclass(self.test, page_test.PageTest):
+ # raise TypeError('"%s" is not a PageTest.' % self.test.__name__)
chrishenry 2014/12/05 06:21:01 Can you revert changes to this file? I'll work on
chrishenry 2014/12/05 20:07:21 I just checked and there is no change necessary he
slamm 2014/12/06 00:39:59 Done.
return self.test()
def CreatePageSet(self, options): # pylint: disable=W0613
@@ -197,8 +197,8 @@ class Benchmark(command_line.Command):
"""
if not hasattr(self, 'page_set'):
raise NotImplementedError('This test has no "page_set" attribute.')
- if not issubclass(self.page_set, page_set.PageSet):
- raise TypeError('"%s" is not a PageSet.' % self.page_set.__name__)
+ #if not issubclass(self.page_set, page_set.PageSet):
+ # raise TypeError('"%s" is not a PageSet.' % self.page_set.__name__)
return self.page_set()
def CreateUserStorySet(self, options):

Powered by Google App Engine
This is Rietveld 408576698