Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: include/gpu/GrXferProcessor.h

Issue 776843004: Use static XPF for porter duff xp factories. (Closed) Base URL: https://skia.googlesource.com/skia.git@xferFactorySolo
Patch Set: Remove extra line Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkXfermode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/gpu/GrXferProcessor.h
diff --git a/include/gpu/GrXferProcessor.h b/include/gpu/GrXferProcessor.h
index 986c22f40b40809b63df20cab735a3dedc601d9f..ce0f39e2c4dc635e7219b9cbd64bcd0c0bd230fe 100644
--- a/include/gpu/GrXferProcessor.h
+++ b/include/gpu/GrXferProcessor.h
@@ -43,7 +43,7 @@ private:
* creates will have. For example, will the XP support RGB coverage or will the XP blend with the
* destination color.
*/
-class GrXPFactory : public GrProgramElement {
+class GrXPFactory : public SkRefCnt {
public:
virtual const GrXferProcessor* createXferProcessor() const = 0;
@@ -58,5 +58,8 @@ private:
typedef GrProgramElement INHERITED;
};
+#define GR_CREATE_STATIC_XP_FACTORY(NAME, XPF_CLASS, ARGS) \
bsalomon 2014/12/03 17:44:56 Do you need this? Do they have to be created on th
egdaniel 2014/12/03 18:12:35 switched off heap and removed macro
+ static XPF_CLASS* NAME = SkNEW_ARGS(XPF_CLASS, ARGS)
+
#endif
« no previous file with comments | « no previous file | src/core/SkXfermode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698