Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 776843004: Use static XPF for porter duff xp factories. (Closed)

Created:
6 years ago by egdaniel
Modified:
6 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@xferFactorySolo
Project:
skia
Visibility:
Public.

Description

Use static XPF for porter duff xp factories. BUG=skia: Committed: https://skia.googlesource.com/skia/+/c016fb8f9fb53dd8d4936c5e9e16a9dc99ab392e

Patch Set 1 #

Patch Set 2 : Remove extra line #

Total comments: 2

Patch Set 3 : Stick statics on stacks #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : Block case statements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -9 lines) Patch
M include/gpu/GrXferProcessor.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkXfermode.cpp View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrPaint.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 2 3 4 5 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
egdaniel
6 years ago (2014-12-03 16:47:54 UTC) #2
bsalomon
https://codereview.chromium.org/776843004/diff/20001/include/gpu/GrXferProcessor.h File include/gpu/GrXferProcessor.h (right): https://codereview.chromium.org/776843004/diff/20001/include/gpu/GrXferProcessor.h#newcode61 include/gpu/GrXferProcessor.h:61: #define GR_CREATE_STATIC_XP_FACTORY(NAME, XPF_CLASS, ARGS) \ Do you need this? ...
6 years ago (2014-12-03 17:44:56 UTC) #3
egdaniel
updated https://codereview.chromium.org/776843004/diff/20001/include/gpu/GrXferProcessor.h File include/gpu/GrXferProcessor.h (right): https://codereview.chromium.org/776843004/diff/20001/include/gpu/GrXferProcessor.h#newcode61 include/gpu/GrXferProcessor.h:61: #define GR_CREATE_STATIC_XP_FACTORY(NAME, XPF_CLASS, ARGS) \ On 2014/12/03 17:44:56, ...
6 years ago (2014-12-03 18:12:35 UTC) #4
bsalomon
lgtm
6 years ago (2014-12-03 18:15:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776843004/40001
6 years ago (2014-12-03 19:12:24 UTC) #7
commit-bot: I haz the power
Failed to apply patch for include/gpu/GrXferProcessor.h: While running git apply --index -3 -p1; error: patch ...
6 years ago (2014-12-03 19:12:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776843004/80001
6 years ago (2014-12-03 19:19:01 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1308)
6 years ago (2014-12-03 19:23:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776843004/100001
6 years ago (2014-12-03 19:32:06 UTC) #15
commit-bot: I haz the power
6 years ago (2014-12-03 19:41:59 UTC) #16
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/c016fb8f9fb53dd8d4936c5e9e16a9dc99ab392e

Powered by Google App Engine
This is Rietveld 408576698