Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 776813004: Introduce new content APIs for persistent notifications. (Closed)

Created:
6 years ago by Peter Beverloo
Modified:
6 years ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-notifications_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, peter+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@n-sw-contentclient
Project:
chromium
Visibility:
Public.

Description

Introduce new content APIs for persistent notifications. This patch introduces two new APIs on the PlatformNotificationService for displaying and closing persistent notifications. Whilst the message filter calls them, there are no implementations yet. BUG=432527 Committed: https://crrev.com/06d77721fe454f99e8e590daea3da0809c56c686 Cr-Commit-Position: refs/heads/master@{#307708}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -5 lines) Patch
M chrome/browser/notifications/platform_notification_service_impl.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_impl.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M content/browser/notifications/notification_message_filter.cc View 1 4 chunks +24 lines, -5 lines 0 comments Download
M content/public/browser/platform_notification_service.h View 1 2 chunks +16 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_notification_manager.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_notification_manager.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Peter Beverloo
+mvanouwerkerk for initial review. This CL depends on https://codereview.chromium.org/774573003/.
6 years ago (2014-12-08 18:19:10 UTC) #2
Michael van Ouwerkerk
lgtm with nit https://codereview.chromium.org/776813004/diff/1/content/browser/notifications/notification_message_filter.cc File content/browser/notifications/notification_message_filter.cc (right): https://codereview.chromium.org/776813004/diff/1/content/browser/notifications/notification_message_filter.cc#newcode65 content/browser/notifications/notification_message_filter.cc:65: GetContentClient()->browser()->GetPlatformNotificationService(); I guess we're on the ...
6 years ago (2014-12-08 19:40:11 UTC) #3
Peter Beverloo
https://codereview.chromium.org/776813004/diff/1/content/browser/notifications/notification_message_filter.cc File content/browser/notifications/notification_message_filter.cc (right): https://codereview.chromium.org/776813004/diff/1/content/browser/notifications/notification_message_filter.cc#newcode65 content/browser/notifications/notification_message_filter.cc:65: GetContentClient()->browser()->GetPlatformNotificationService(); On 2014/12/08 19:40:11, Michael van Ouwerkerk wrote: > ...
6 years ago (2014-12-09 18:39:26 UTC) #4
Peter Beverloo
+dewittj
6 years ago (2014-12-09 19:41:29 UTC) #6
dewittj
lgtm
6 years ago (2014-12-09 20:59:47 UTC) #7
Peter Beverloo
Thanks! +avi for content/
6 years ago (2014-12-09 21:54:40 UTC) #9
Avi (use Gerrit)
lgtm stampity stamp
6 years ago (2014-12-10 00:19:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776813004/20001
6 years ago (2014-12-10 15:16:23 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-10 16:11:18 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-10 16:12:43 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/06d77721fe454f99e8e590daea3da0809c56c686
Cr-Commit-Position: refs/heads/master@{#307708}

Powered by Google App Engine
This is Rietveld 408576698