Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(112)

Issue 7768005: Merge 94637 - REGRESSION(r94274): The inner text value of an input element is not updated when in... (Closed)

Created:
9 years, 1 month ago by Ilya Sherman
Modified:
9 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 94637 - REGRESSION(r94274): The inner text value of an input element is not updated when input.value is set https://bugs.webkit.org/show_bug.cgi?id=67681 Reviewed by Kent Tamura. Source/WebCore: The bug was caused by HTMLInputElement::setValue's not clearing m_suggestedValue before updateInnerTextValue is called. Since updateInnerTextValue uses the suggested value when one is present, we need to clear m_suggestedValue in advance. Test: fast/forms/suggested-value-after-setvalue.html * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): LayoutTests: Added a test that overrides the suggested value by modifying the value IDL attribute of an input element. * fast/forms/suggested-value-after-setvalue-expected.txt: Added. * fast/forms/suggested-value-after-setvalue.html: Added. TBR=rniwa@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + LayoutTests/fast/forms/suggested-value-after-setvalue.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/suggested-value-after-setvalue-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/html/HTMLInputElement.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Ilya Sherman
9 years, 1 month ago (2011-09-09 23:04:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698