Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 776743002: Make v8 inspector not crash (Closed)

Created:
6 years ago by eseidel
Modified:
6 years ago
Reviewers:
yurys, ojan
CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Make v8 inspector not crash It was attempting to load InjectedScript, etc. with the wrong path and hitting a CHECK(). I moved InjectedScript and DebugScript into the v8_inspector directory and fixed their loading. I also broke the dependency from v8_inspector onto engine/platform by moving the horrible Platform::loadResource hack out of PlatformImpl into a new file just for v8_inspector. In this process I also found some (broken!) code for showing the broken image icon which if we ever hit would just have crashed, so I removed that code as well. BUG=435243 R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c64d1af98e121a93b561ef1cbc34e6a4481260e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -650 lines) Patch
D sky/engine/bindings/core/v8/DebuggerScript.js View 1 chunk +0 lines, -565 lines 0 comments Download
M sky/engine/core/fetch/ImageResource.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/fetch/ImageResource.cpp View 2 chunks +0 lines, -25 lines 0 comments Download
M sky/engine/platform/graphics/Image.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/platform/graphics/Image.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M sky/engine/public/platform/Platform.h View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/v8_inspector/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + sky/engine/v8_inspector/DebuggerScript.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M sky/engine/v8_inspector/InjectedScriptManager.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/v8_inspector/ScriptDebugServer.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
A sky/engine/v8_inspector/read_from_source_tree.h View 1 chunk +18 lines, -0 lines 0 comments Download
A sky/engine/v8_inspector/read_from_source_tree.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M sky/viewer/platform/platform_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/viewer/platform/platform_impl.cc View 2 chunks +0 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eseidel
6 years ago (2014-12-02 23:06:45 UTC) #2
ojan
lgtm Seems fine. It's not clear to me what the crash fix is. Could you ...
6 years ago (2014-12-03 00:05:23 UTC) #4
eseidel
fixed
6 years ago (2014-12-03 00:32:33 UTC) #5
eseidel
Committed patchset #1 (id:1) manually as c64d1af98e121a93b561ef1cbc34e6a4481260e5 (presubmit successful).
6 years ago (2014-12-03 00:47:21 UTC) #6
yurys
6 years ago (2014-12-03 07:25:14 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698