|
|
Make v8 inspector not crash
It was attempting to load InjectedScript, etc.
with the wrong path and hitting a CHECK().
I moved InjectedScript and DebugScript into
the v8_inspector directory and fixed their loading.
I also broke the dependency from v8_inspector
onto engine/platform by moving the horrible
Platform::loadResource hack out of PlatformImpl
into a new file just for v8_inspector.
In this process I also found some (broken!)
code for showing the broken image icon which
if we ever hit would just have crashed, so
I removed that code as well.
BUG= 435243
R=ojan@chromium.org
Committed: https://chromium.googlesource.com/external/mojo/+/c64d1af98e121a93b561ef1cbc34e6a4481260e5
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+63 lines, -650 lines) |
Patch |
 |
D |
sky/engine/bindings/core/v8/DebuggerScript.js
|
View
|
|
1 chunk |
+0 lines, -565 lines |
0 comments
|
Download
|
 |
M |
sky/engine/core/fetch/ImageResource.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/engine/core/fetch/ImageResource.cpp
|
View
|
|
2 chunks |
+0 lines, -25 lines |
0 comments
|
Download
|
 |
M |
sky/engine/platform/graphics/Image.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/engine/platform/graphics/Image.cpp
|
View
|
|
1 chunk |
+0 lines, -11 lines |
0 comments
|
Download
|
 |
M |
sky/engine/public/platform/Platform.h
|
View
|
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
 |
M |
sky/engine/v8_inspector/BUILD.gn
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
A + |
sky/engine/v8_inspector/DebuggerScript.js
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
M |
sky/engine/v8_inspector/InjectedScriptManager.cpp
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
sky/engine/v8_inspector/ScriptDebugServer.cpp
|
View
|
|
2 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
 |
A |
sky/engine/v8_inspector/read_from_source_tree.h
|
View
|
|
1 chunk |
+18 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sky/engine/v8_inspector/read_from_source_tree.cc
|
View
|
|
1 chunk |
+33 lines, -0 lines |
0 comments
|
Download
|
 |
M |
sky/viewer/platform/platform_impl.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/viewer/platform/platform_impl.cc
|
View
|
|
2 chunks |
+0 lines, -27 lines |
0 comments
|
Download
|
Total messages: 7 (2 generated)
|