Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 776693002: Clean forward declaration in public (Closed)

Created:
6 years ago by zhaoze.zhou
Modified:
6 years ago
Reviewers:
tkent, Mike West, adamk, rwlbuis
CC:
blink-reviews, eustas+blink_chromium.org, caseq+blink_chromium.org, aandrey+blink_chromium.org, loislo+blink_chromium.org, pfeldman+blink_chromium.org, malch+blink_chromium.org, philipj_slow, yurys+blink_chromium.org, dcheng, vsevik+blink_chromium.org, feature-media-reviews_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, dgrogan, eric.carlson_apple.com, cmumford, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, jsbell+idb_chromium.org, lushnikov+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean forward declaration in public These forward references are not needed. After this patch, public/ dirctory has no unneeded forward references anymore. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186556

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : fix FakeWebPlugin #

Patch Set 5 : fix fakewebplugin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -105 lines) Patch
M Source/web/WebViewImpl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/FakeWebPlugin.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/FakeWebPlugin.cpp View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M public/platform/Platform.h View 2 chunks +0 lines, -2 lines 0 comments Download
M public/platform/WebApplicationCacheHost.h View 1 chunk +0 lines, -2 lines 0 comments Download
M public/platform/WebAudioBus.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebContentLayerClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebData.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebDragData.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebExternalTextureLayer.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M public/platform/WebExternalTextureLayerClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebFederatedCredential.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M public/platform/WebIDBCallbacks.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebIDBDatabase.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebIDBKeyRange.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebLayerTreeView.h View 1 chunk +0 lines, -3 lines 0 comments Download
M public/platform/WebLocalCredential.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M public/platform/WebMediaPlayer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M public/platform/WebMediaPlayerClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M public/platform/WebMediaStream.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebMediaStreamCenter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M public/platform/WebMediaStreamCenterClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebPrescientNetworking.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M public/platform/WebRTCPeerConnectionHandler.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebServiceWorkerProvider.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebSocketHandleClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebSpeechSynthesizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebString.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M public/platform/WebURLLoadTiming.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebURLRequest.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebArrayBuffer.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebBindings.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebDataSource.h View 1 chunk +0 lines, -2 lines 0 comments Download
M public/web/WebDevToolsAgent.h View 1 chunk +0 lines, -8 lines 0 comments Download
M public/web/WebDevToolsAgentClient.h View 1 chunk +0 lines, -3 lines 0 comments Download
M public/web/WebDevToolsFrontendClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M public/web/WebDocument.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebFont.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebFormElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebFrame.h View 1 chunk +0 lines, -3 lines 0 comments Download
M public/web/WebFrameClient.h View 3 chunks +0 lines, -7 lines 0 comments Download
M public/web/WebLocalFrame.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebPermissionClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebPlugin.h View 1 chunk +0 lines, -3 lines 0 comments Download
M public/web/WebRange.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebRemoteFrame.h View 1 chunk +2 lines, -0 lines 0 comments Download
M public/web/WebSettings.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebSharedWorkerConnector.h View 1 chunk +0 lines, -2 lines 0 comments Download
M public/web/WebSpeechRecognitionHandle.h View 1 chunk +0 lines, -2 lines 0 comments Download
M public/web/WebSpeechRecognizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebSurroundingText.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebUserMediaClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebUserMediaRequest.h View 1 chunk +0 lines, -2 lines 0 comments Download
M public/web/WebView.h View 1 chunk +0 lines, -4 lines 0 comments Download
M public/web/WebViewClient.h View 1 chunk +0 lines, -7 lines 0 comments Download
M public/web/WebWidget.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
zhaoze.zhou
On 2014/12/02 23:26:38, zhaoze.zhou wrote: > mailto:zhaoze.zhou@partner.samsung.com changed reviewers: > + mailto:adamk@chromium.org Hi, there's several ...
6 years ago (2014-12-02 23:28:37 UTC) #2
adamk
I'm not an OWNER in public/, so I won't be much help for this patch.
6 years ago (2014-12-02 23:29:28 UTC) #3
zhaoze.zhou
On 2014/12/02 23:29:28, adamk wrote: > I'm not an OWNER in public/, so I won't ...
6 years ago (2014-12-02 23:36:43 UTC) #5
tkent
lgtm
6 years ago (2014-12-03 00:04:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776693002/20001
6 years ago (2014-12-03 00:05:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/18771) mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/27706) mac_blink_rel ...
6 years ago (2014-12-03 00:16:02 UTC) #10
zhaoze.zhou
On 2014/12/03 00:04:45, tkent wrote: > lgtm Sorry that didn't make it clear to you. ...
6 years ago (2014-12-03 14:43:35 UTC) #11
tkent
I think this CL does the right thing. Chromium code should have forward class declarations ...
6 years ago (2014-12-03 23:41:43 UTC) #12
zhaoze.zhou
On 2014/12/03 23:41:43, tkent wrote: > I think this CL does the right thing. Chromium ...
6 years ago (2014-12-03 23:53:56 UTC) #13
zhaoze.zhou
On 2014/12/03 23:53:56, zhaoze.zhou wrote: > On 2014/12/03 23:41:43, tkent wrote: > > I think ...
6 years ago (2014-12-04 23:28:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776693002/120001
6 years ago (2014-12-04 23:37:35 UTC) #18
commit-bot: I haz the power
6 years ago (2014-12-05 00:22:23 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186556

Powered by Google App Engine
This is Rietveld 408576698