Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: Source/core/rendering/RenderObject.cpp

Issue 776653003: Don't delete a flow thread just because it becomes childless. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Code review. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/multicol/remove-all-children-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderObject.cpp
diff --git a/Source/core/rendering/RenderObject.cpp b/Source/core/rendering/RenderObject.cpp
index ade24833002626b55b6ec9a6bf42e23f145039b4..31ef55b2640d041f77aa202fa76652f8aeadb880 100644
--- a/Source/core/rendering/RenderObject.cpp
+++ b/Source/core/rendering/RenderObject.cpp
@@ -2400,7 +2400,10 @@ void RenderObject::destroyAndCleanupAnonymousWrappers()
// Anonymous block continuations are tracked and destroyed elsewhere (see the bottom of RenderBlock::removeChild)
if (destroyRootParent->isRenderBlock() && toRenderBlock(destroyRootParent)->isAnonymousBlockContinuation())
break;
- // Column spans are tracked elsewhere, so we can't destroy them here.
+ // A flow thread is tracked by its containing block. Whether its children are removed or not is irrelevant.
+ if (destroyRootParent->isRenderFlowThread())
+ break;
+ // Column spans are tracked elsewhere.
if (destroyRootParent->isAnonymousColumnSpanBlock())
break;
« no previous file with comments | « LayoutTests/fast/multicol/remove-all-children-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698