Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc

Issue 776603003: Changed the GPU Tracer so the category names can be customized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Service side GPU trace not turned on when device is turned on Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/command_buffer/service/gpu_tracer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc
index 3fadaf07634a2c1180010488adc22e69c7ddada0..86b61ac7c3ab987d7bcf0aecceb310a867f5612a 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc
@@ -37,12 +37,16 @@ class GLES2DecoderTest3 : public GLES2DecoderTestBase {
INSTANTIATE_TEST_CASE_P(Service, GLES2DecoderTest3, ::testing::Bool());
TEST_P(GLES2DecoderTest3, TraceBeginCHROMIUM) {
- const uint32 kBucketId = 123;
+ const uint32 kCategoryBucketId = 123;
+ const uint32 kNameBucketId = 234;
+
+ const char kCategory[] = "test_category";
const char kName[] = "test_command";
- SetBucketAsCString(kBucketId, kName);
+ SetBucketAsCString(kCategoryBucketId, kCategory);
+ SetBucketAsCString(kNameBucketId, kName);
TraceBeginCHROMIUM begin_cmd;
- begin_cmd.Init(kBucketId);
+ begin_cmd.Init(kCategoryBucketId, kNameBucketId);
EXPECT_EQ(error::kNoError, ExecuteCmd(begin_cmd));
}
@@ -53,12 +57,16 @@ TEST_P(GLES2DecoderTest3, TraceEndCHROMIUM) {
EXPECT_EQ(error::kNoError, ExecuteCmd(end_cmd));
EXPECT_EQ(GL_INVALID_OPERATION, GetGLError());
- const uint32 kBucketId = 123;
+ const uint32 kCategoryBucketId = 123;
+ const uint32 kNameBucketId = 234;
+
+ const char kCategory[] = "test_category";
const char kName[] = "test_command";
- SetBucketAsCString(kBucketId, kName);
+ SetBucketAsCString(kCategoryBucketId, kCategory);
+ SetBucketAsCString(kNameBucketId, kName);
TraceBeginCHROMIUM begin_cmd;
- begin_cmd.Init(kBucketId);
+ begin_cmd.Init(kCategoryBucketId, kNameBucketId);
EXPECT_EQ(error::kNoError, ExecuteCmd(begin_cmd));
end_cmd.Init();
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/command_buffer/service/gpu_tracer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698