Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 776603002: Revert of Change to Shill's IPConfig objects. (Closed)

Created:
6 years ago by pfeldman
Modified:
6 years ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Change to Shill's IPConfig objects. (patchset #1 id:1 of https://codereview.chromium.org/762243002/) Reason for revert: Breaks the build: http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/7051 Original issue's description: > Change to Shill's IPConfig objects. > > Before a recent Shill change, Static and Saved IP config properties were stored in toplevel properties with prefixed keys like kStaticIPAddressProperty. > This change makes use of Shill now exposing these properties nested under a StaticIPConfig and SavedIPConfig dictionary. > > This also makes the translation between a list of nameservers and a comma-separated string obsolete. > > BUG=411289 > > Committed: https://crrev.com/ac2d359b101e4c97455125958db4a999bf26135f > Cr-Commit-Position: refs/heads/master@{#306400} TBR=stevenjb@chromium.org,pneubeck@chromium.org NOTREECHECKS=true NOTRY=true BUG=411289 Committed: https://crrev.com/aed3df70b1a9b209d415220f49ac2fad5ccfb15d Cr-Commit-Position: refs/heads/master@{#306412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -56 lines) Patch
M chromeos/network/onc/onc_translation_tables.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/network/onc/onc_translation_tables.cc View 3 chunks +18 lines, -15 lines 0 comments Download
M chromeos/network/onc/onc_translator_onc_to_shill.cc View 4 chunks +28 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 4 chunks +23 lines, -19 lines 0 comments Download
M chromeos/test/data/network/shill_ethernet.json View 1 chunk +4 lines, -6 lines 0 comments Download
M chromeos/test/data/network/shill_ethernet_with_ipconfig.json View 1 chunk +8 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pfeldman
Created Revert of Change to Shill's IPConfig objects.
6 years ago (2014-12-02 17:43:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776603002/1
6 years ago (2014-12-02 17:44:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-02 17:44:50 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-02 17:45:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aed3df70b1a9b209d415220f49ac2fad5ccfb15d
Cr-Commit-Position: refs/heads/master@{#306412}

Powered by Google App Engine
This is Rietveld 408576698