Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 776563002: Better message location for 'super(...)' restriction error. (Closed)

Created:
6 years ago by Dmitry Lomov (no reviews)
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Better message location for 'super(...)' restriction error. R=arv@chromium.org BUG=v8:3330 LOG=N

Patch Set 1 #

Patch Set 2 : Tests #

Patch Set 3 : Minor #

Patch Set 4 : One more #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -23 lines) Patch
M src/compiler.cc View 3 chunks +9 lines, -10 lines 0 comments Download
A + test/message/super-constructor.js View 1 1 chunk +7 lines, -7 lines 0 comments Download
A test/message/super-constructor.out View 1 1 chunk +8 lines, -0 lines 0 comments Download
A + test/message/super-constructor-extra-statement.js View 1 1 chunk +8 lines, -6 lines 0 comments Download
A test/message/super-constructor-extra-statement.out View 1 1 chunk +8 lines, -0 lines 0 comments Download
M test/message/testcfg.py View 1 2 3 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
Dmitry Lomov (no reviews)
PTAL
6 years ago (2014-12-02 14:04:50 UTC) #1
arv (Not doing code reviews)
Can we add a test for this?
6 years ago (2014-12-02 14:20:24 UTC) #2
Dmitry Lomov (no reviews)
PTAL https://codereview.chromium.org/776563002/diff/60001/test/message/testcfg.py File test/message/testcfg.py (right): https://codereview.chromium.org/776563002/diff/60001/test/message/testcfg.py#newcode78 test/message/testcfg.py:78: if not string.strip(): return True We strip expected ...
6 years ago (2014-12-08 14:35:51 UTC) #3
arv (Not doing code reviews)
LGTM
6 years ago (2014-12-08 15:07:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776563002/60001
6 years ago (2014-12-08 15:26:51 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-08 15:55:01 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001)

Powered by Google App Engine
This is Rietveld 408576698