Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: LayoutTests/http/tests/serviceworker/unregister-controller.html

Issue 776373003: ServiceWorker cleanup: remove wait_for_update() in favor of r.installing in most tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/serviceworker/unregister-controller.html
diff --git a/LayoutTests/http/tests/serviceworker/unregister-controller.html b/LayoutTests/http/tests/serviceworker/unregister-controller.html
index 0517fdaad292ac141300ec916e9e4f54c07b11c7..fc05f7763f5914fe733b6a04dead432d58a374ff 100644
--- a/LayoutTests/http/tests/serviceworker/unregister-controller.html
+++ b/LayoutTests/http/tests/serviceworker/unregister-controller.html
@@ -15,10 +15,7 @@ async_test(function(t) {
service_worker_unregister_and_register(t, worker_url, scope)
.then(function(r) {
registration = r;
- return wait_for_update(t, registration);
- })
- .then(function(worker) {
- return wait_for_state(t, worker, 'activated');
+ return wait_for_state(t, r.installing, 'activated');
})
.then(function() {
return with_iframe(scope);
@@ -52,10 +49,7 @@ async_test(function(t) {
service_worker_unregister_and_register(t, worker_url, scope)
.then(function(r) {
registration = r;
- return wait_for_update(t, registration);
- })
- .then(function(worker) {
- return wait_for_state(t, worker, 'activated');
+ return wait_for_state(t, r.installing, 'activated');
})
.then(function() {
return registration.unregister();
@@ -85,10 +79,7 @@ async_test(function(t) {
service_worker_unregister_and_register(t, worker_url, scope)
.then(function(r) {
registration = r;
- return wait_for_update(t, registration);
- })
- .then(function(worker) {
- return wait_for_state(t, worker, 'activated');
+ return wait_for_state(t, r.installing, 'activated');
})
.then(function() {
return with_iframe(scope);
« no previous file with comments | « LayoutTests/http/tests/serviceworker/state.html ('k') | LayoutTests/http/tests/serviceworker/unregister-then-register.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698