Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 776343003: Revert of Improve the logic for hiding the multi-window resize handle (Closed)

Created:
6 years ago by pkotwicz
Modified:
6 years ago
Reviewers:
flackr
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_multi_window
Project:
chromium
Visibility:
Public.

Description

Revert of Improve the logic for hiding the multi-window resize handle (patchset #2 id:20001 of https://codereview.chromium.org/771543002/) Reason for revert: This CL broke: FullscreenControllerInteractiveTest.EscapingMouseLock FullscreenControllerInteractiveTest.TestTabExitsMouseLockOnGoBack FullscreenControllerInteractiveTest.TestTabExitsMouseLockOnNavigation Original issue's description: > Improve the logic for hiding the multi-window resize handle > > Improvements: > - The resize handle no longer hides when a user moves the mouse along the shared > window edge > - The resize handle no longer hides when a user moves the mouse over the resize > shadow > - Removed call to redundant MultiWindowResizeController::DelayedHide() > > BUG=None > TEST=MultiWindowResizeControllerTest.IsOverWindows > > Committed: https://crrev.com/ca6988df595e520e353722bbf5361c4dc0d0ee86 > Cr-Commit-Position: refs/heads/master@{#306874} TBR=flackr@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/def3769afef231a4b44d5f2c4e766f5b6cb42472 Cr-Commit-Position: refs/heads/master@{#306961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -195 lines) Patch
M ash/wm/workspace/multi_window_resize_controller.h View 4 chunks +12 lines, -8 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 13 chunks +57 lines, -87 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller_unittest.cc View 12 chunks +17 lines, -100 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pkotwicz
Created Revert of Improve the logic for hiding the multi-window resize handle
6 years ago (2014-12-05 03:03:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776343003/1
6 years ago (2014-12-05 03:05:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-05 03:06:45 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-05 03:07:30 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/def3769afef231a4b44d5f2c4e766f5b6cb42472
Cr-Commit-Position: refs/heads/master@{#306961}

Powered by Google App Engine
This is Rietveld 408576698