Source/core/frame/ImageBitmap.cpp - Issue 776293002: Window.createImageBitmap(HTMLCanvasElement) should copy the front buffer of WebGL, not back buffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/ImageBitmap.cpp

Issue 776293002: Window.createImageBitmap(HTMLCanvasElement) should copy the front buffer of WebGL, not back buffer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/ImageBitmap.cpp

diff --git a/Source/core/frame/ImageBitmap.cpp b/Source/core/frame/ImageBitmap.cpp

index ae200eaece78105c65fc4256df2b51b7b43192e6..ac5ebbf2e0189cf06389827eb86e1137adfa957c 100644

--- a/Source/core/frame/ImageBitmap.cpp

+++ b/Source/core/frame/ImageBitmap.cpp

@@ -82,7 +82,7 @@ ImageBitmap::ImageBitmap(HTMLCanvasElement* canvas, const IntRect& cropRect)

IntRect srcRect = intersection(cropRect, IntRect(IntPoint(), canvas->size()));

m_bitmapRect = IntRect(IntPoint(std::max(0, -cropRect.x()), std::max(0, -cropRect.y())), srcRect.size());

ASSERT(canvas->isPaintable());

- m_bitmap = cropImage(canvas->copiedImage(BackBuffer).get(), cropRect);

+ m_bitmap = cropImage(canvas->copiedImage(FrontBuffer).get(), cropRect);

}

ImageBitmap::ImageBitmap(ImageData* data, const IntRect& cropRect)

« no previous file with comments | « LayoutTests/fast/canvas/canvas-createImageBitmap-webgl-expected.txt ('k') | no next file » | no next file with comments »