Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 776273002: Fix SKPBench tiling so MPD and non-MPD match (Closed)

Created:
6 years ago by robertphillips
Modified:
6 years ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix SKPBench tiling so MPD and non-MPD match Two issues with the SKPBench tile computation were causing the MPD path to do more work: The clip from the parent canvas wasn't being used to trim content off the edges of the MPD tiles The non-MPD path was not taking the scale into account in its tile placement (resulting in it having fewer, larger active tiles when scaling). Committed: https://skia.googlesource.com/skia/+/63242d7d24917f836eace34ee20faeb49def5e67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M bench/SKPBench.cpp View 2 chunks +12 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
robertphillips
6 years ago (2014-12-04 15:43:51 UTC) #2
mtklein
lgtm
6 years ago (2014-12-04 16:21:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776273002/1
6 years ago (2014-12-04 16:21:57 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-04 16:31:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/63242d7d24917f836eace34ee20faeb49def5e67

Powered by Google App Engine
This is Rietveld 408576698